[HOLD for payment 2023-11-22] [$500] Incorrect LHN subtitle when last message is flagged as assault

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.88.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @rojiphil
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1698055337881839

Action Performed:

User A’s App

1. Add a task to a Chat Report with User B.
2. Add a task message to the Task Report.
3. Cancel the task using 3dots menu in Task Report.
4. Navigate back to Chat Report. The canceled task will be shown as [Deleted task] in report screen.
5. Add a new message to the chat report (say Message to be flagged as assault)
   User B’s App
6. Now, move to the app where User B is signed-in and navigate to chat report with User A.
7. Flag the message (i.e. Message to be flagged as assault) with User A as assault.

Expected Result:

LHN subtitle for Chat Report should show ’[Deleted task]’

Actual Result:

LHN subtitle for Chat Report shows ’This is the beginning…’

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

assault-android-native.mp4

Android: mWeb Chrome

assault-mweb-chrome.mp4

iOS: Native

assault-ios-native.mp4

iOS: mWeb Safari

assault-mweb-safari.mp4

MacOS: Chrome / Safari

Recording.5121.mp4

issue-incorrect-lhn.mp4

MacOS: Desktop

assault-desktop.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0161986a581b3f1b65
• Upwork Job ID: 1718970549355294720
• Last Price Increase: 2023-11-06
• Automatic offers:
• jjcoffee | Reviewer | 27549205
• dukenv0307 | Contributor | 27549207

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0161986a581b3f1b65

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[kbecciv]

Proposal by: @rojiphil
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1698055337881839

Proposal

Please re-state the problem that we are trying to solve in this issue.

When the last visible action is a message that has been moderated as pending removal and the immediate previous message is a canceled task with visible comments, the LHN subtitle does not show as [Deleted task]. This is the problem we are trying to solve.

What is the root cause of that problem?

When the last visible action is a message that has been moderated as pending removal, we set the last message text here within getLastMessageTextForReport. Here, we check if the one before this action is pending for removal (i.e. moderated). If so, we retrieve and use the message text from the one before the moderated message. However, none of the special cases are applied as shown here when compared to the ones handled within getLastMessageTextForReport function here. In our case here, the special case of canceled task with visible actions was not handled as shown here. This is the root cause of the problem.

What changes do you think we should make in order to solve the problem?

To solve the problem,

1. We can check if the current action is a whisper action. If so, we can retrieve the previous action and check if it is moderated for the purpose of removal. If it is pending for removal, we can update the lastReportAction here with the one before the moderated message. Now, since the lastReportAction is updated correctly, any special cases will be smoothly applied here.
   The changes can be like this here:

  if(ReportActionUtils.isWhisperAction(lastReportAction))
  {
    // If this is a whisper action, let us check if the one before this action is pending for removal (i.e. moderated)
    // If it is so, let us display the message text from the visible action previous to the moderated one.
    const lastNonWhisper = _.find(allSortedReportActions[report.reportID], (action) => !ReportActionUtils.isWhisperAction(action)) || {};
    if (ReportActionUtils.isPendingRemove(lastNonWhisper)) {
      lastReportAction =
        _.find(
          allSortedReportActions[report.reportID],
          (action) => ReportActionUtils.shouldReportActionBeVisibleAsLastAction(action) && !ReportActionUtils.isCreatedAction(action),
        ) || {};
    }
  }

2. Since we have moved the functionality to proactively update the lastReportAction, we can remove this code here

What alternative solutions did you explore? (Optional)

[rojiphil]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When the last visible action is a message that has been moderated as pending removal and the immediate previous message is a canceled task with visible comments, the LHN subtitle does not show as [Deleted task]. This is the problem we are trying to solve.

What is the root cause of that problem?

When the last visible action is a message that has been moderated as pending removal, we set the last message text here within getLastMessageTextForReport. Here, we check if the one before this action is pending for removal (i.e. moderated). If so, we retrieve and use the message text from the one before the moderated message. However, none of the special cases are applied as shown here when compared to the ones handled within getLastMessageTextForReport function here. In our case here, the special case of canceled task with visible actions was not handled as shown here. This is the root cause of the problem.

What changes do you think we should make in order to solve the problem?

To solve the problem,

1. We can check if the current action is a whisper action. If so, we can retrieve the previous action and check if it is moderated for the purpose of removal. If it is pending for removal, we can update the lastReportAction here with the one before the moderated message. Now, since the lastReportAction is updated correctly, any special cases will be smoothly applied here.
   The changes can be like this here:

  if(ReportActionUtils.isWhisperAction(lastReportAction))
  {
    // If this is a whisper action, let us check if the one before this action is pending for removal (i.e. moderated)
    // If it is so, let us display the message text from the visible action previous to the moderated one.
    const lastNonWhisper = _.find(allSortedReportActions[report.reportID], (action) => !ReportActionUtils.isWhisperAction(action)) || {};
    if (ReportActionUtils.isPendingRemove(lastNonWhisper)) {
      lastReportAction =
        _.find(
          allSortedReportActions[report.reportID],
          (action) => ReportActionUtils.shouldReportActionBeVisibleAsLastAction(action) && !ReportActionUtils.isCreatedAction(action),
        ) || {};
    }
  }

2. Since we have moved the functionality to proactively update the lastReportAction, we can remove this code here

What alternative solutions did you explore? (Optional)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

LHN subtitle for Chat Report shows ’This is the beginning…’

What is the root cause of that problem?

The logic to get the lastReportAction here is not correct. In here we're getting the last report action to show as last message, for which the shouldReportActionBeVisible is not correct since that one is for getting the last report action in the ReportActionList. When we use it here it will include report actions that should not show as last message, for example Whisper report action. When it gets the Whisper as the lastReportAction, it will either:

• Fallback to the lastMessageText of the report here, which is incorrect because we should get the last message text from the non-whisper report action instead
• If the last non whisper action is pending removed, it will use this logic to get the text of the latestVisibleAction, which is also not correct since that report action should be processed through these conditions to get the correct message.

So not only do we have problem in the pending removed case in this issue, we also have problem when there's no pending remove, and just a Deleted task action and a subsequent whisper action (for example, in the case of deleted task action, then a user is added to the workspace and see the welcome message)

What changes do you think we should make in order to solve the problem?

Update this to

(reportAction) => ReportActionUtils.shouldReportActionBeVisibleAsLastAction(reportAction)

The shouldReportActionBeVisible is specifically built for getting the last visible action to get last message text. It already excludes things like Whisper and pending remove message. So we can remove the pending message check here.

If we simply move the pending remove action check outside to the beginning of getLastMessageTextForReport, the below case will still show incorrect last message.

we also have problem when there's no pending remove, and just a Deleted task action and a subsequent whisper action (for example, in the case of deleted task action, then a user is added to the workspace and see the welcome message)

What alternative solutions did you explore? (Optional)

NA