[$500] Web - Whisper message displayed in public room only after page refresh

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.90.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Whisper message from concierge displayed only after page refresh

Expected Result:

Whisper message from concierge displayed

Actual Result:

1. Create a public room as an admin and copy the report URL that looks like http:staging.new.expensify.comr/2119824243178364
2. Sign out of admin and paste the URL
3. Create a very new account and go to public room

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

275666055-0a0412c3-1083-41b2-bd95-69e52e7f9f28.mp4

MacOS: Desktop

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f5bdf03fcb2be030

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[kbecciv]

Created issue per request https://github.com/Expensify/Web-Expensify/pull/38486#issuecomment-1765699411

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Whisper message displayed in public room only after page refresh

What is the root cause of that problem?

When users are not authenticated, they can not get the whisper messages from concierge. After they login, we don't have the logic to re-fetch the report

What changes do you think we should make in order to solve the problem?

In ReportActionsView we should add the logic to call openReportIfNecessary right after users login successfully. The logic is quite same as what we did when the network changed

    useEffect(() => {
        const prevTokenType = prevAuthTokenType.current;
        const wasLoginChangedDetected = prevTokenType === 'anonymousAccount' && !props.session.authTokenType
        if (wasLoginChangedDetected && didUserLogInDuringSession() && isUserCreatedPolicyRoom(props.report)) {
            if (isReportFullyVisible) {
                openReportIfNecessary();
            } else {
                Report.reconnect(reportID);
            }
        }
        prevAuthTokenType.current = props.session.authTokenType;
    }, [props.session, props.report, isReportFullyVisible]);

Result

Screen.Recording.2023-10-27.at.12.38.20.mov

[melvin-bot]

📣 @WhiteStone-Mac1! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>