[$500] Chat - "Copy To Clipboard show "requested" for split action."

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.90.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1698130953409749

Action Performed:

1. Try to split with 3,4 users.
2. Hover on that split action, click copy to clipboard.
3. Paste the text to browser.
4. The text shows "Requested...." instead of "Split...."

Expected Result:

The clipboard text should be "split ...." instead of "requested..."

Actual Result:

The clipboard text shows "requested..." for split action.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Screen.Recording.2023-10-24.at.14.38.19.mov

Android: mWeb Chrome

Screen.Recording.2023-10-24.at.14.44.43.mov

iOS: Native

Screen.Recording.2023-10-24.at.14.38.19.1.mov

iOS: mWeb Safari

RPReplay_Final1698132864.2.MP4

MacOS: Chrome / Safari

Screen.Recording.2023-10-24.at.13.47.20.mov

Recording.5136.mp4

MacOS: Desktop

Screen.Recording.2023-10-24.at.14.35.28.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014f01b7930e0979a6
• Upwork Job ID: 1716869694506221568
• Last Price Increase: 2023-10-24

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014f01b7930e0979a6

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[kbecciv]

Proposal by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1698130953409749

Proposal

Please re-state the problem that we are trying to solve in this issue.

Copy To Clipboard show "requested" for instead of "Split" for split action.

What is the root cause of that problem?

When getting message of MoneyRequestAction, we didn't have a check for split action here, so even it's split action, it still showed the requested amount text.

App/src/libs/ReportUtils.js

Lines 4058 to 4061 in d282473

	displayMessage = Localize.translateLocal('iou.requestedAmount', {
	formattedAmount,
	comment,
	});

What changes do you think we should make in order to solve the problem?

Add a second param called isSplitAction for getIOUReportActionDisplayMessage.
Add a check in here if it's split action we should use split text instead.

 displayMessage = Localize.translateLocal(isSplitAction ? 'iou.didSplitAmount' : 'iou.requestedAmount', {
            formattedAmount,
            comment,
        });

Also add the second params of getIOUReportActionDisplayMessage inside onPress of report action menu:

const displayMessage = ReportUtils.getIOUReportActionDisplayMessage(reportAction, ReportActionsUtils.isSplitBillAction(reportAction));

What alternative solutions did you explore? (Optional)

N/A

[hungvu193]

Proposal by: @hungvu193 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1698130953409749

Proposal

Please re-state the problem that we are trying to solve in this issue.

Copy To Clipboard show "requested" for instead of "Split" for split action.

What is the root cause of that problem?

When getting message of MoneyRequestAction, we didn't have a check for split action here, so even it's split action, it still showed the requested amount text.

App/src/libs/ReportUtils.js

Lines 4058 to 4061 in d282473

	displayMessage = Localize.translateLocal('iou.requestedAmount', {
	formattedAmount,
	comment,
	});

What changes do you think we should make in order to solve the problem?

Add a second param called isSplitAction for getIOUReportActionDisplayMessage. Add a check in here if it's split action we should use split text instead.

 displayMessage = Localize.translateLocal(isSplitAction ? 'iou.didSplitAmount' : 'iou.requestedAmount', {
            formattedAmount,
            comment,
        });

Also add the second params of getIOUReportActionDisplayMessage inside onPress of report action menu:

const displayMessage = ReportUtils.getIOUReportActionDisplayMessage(reportAction, ReportActionsUtils.isSplitBillAction(reportAction));

What alternative solutions did you explore? (Optional)

N/A