[HOLD for payment 2023-11-21] [DISTANCE] [$500] LOW: BUG: individuals can be selected for distance requests

[neil-marcellini]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.3.89-6
Reproducible in staging?: yes
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @Ashim Sharma
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693731984757459

Action Performed:

1. go to fab button -> request money -> distance
2. Select valid addresses in start and finish points
3. click next
4. Now type in and select a user's mail address . eg user1@gmail.com

Expected Result:

Individuals should not appear as participant options for distance requests

Actual Result:

Individuals do appear as participant options for distance requests. After selecting one the confirmation page shows the amount as $0.

Workaround:

You will get an error after requesting and can make a request to a workspace instead.

Platforms:

Which of our officially supported platforms is this issue occurring on?
All

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

https://expensify.enterprise.slack.com/files/U04H96S40LC/F05RFFKS9T2/screen_recording_2023-09-03_at_2.45.37_pm.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c5428782ec334786
• Upwork Job ID: 1716560993895415808
• Last Price Increase: 2023-10-23
• Automatic offers:
• cubuspl42 | Reviewer | 27491620
• neonbhai | Contributor | 27491621

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c5428782ec334786

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Individuals can be selected for distance requests

What is the root cause of that problem?

We can invite individuals in MoneyRequestParticipantsSelector even in DistanceRequest Flow

What changes do you think we should make in order to solve the problem?

We should pass canInviteUser param as false when we are in a Distance Request flow (i.e., isDistanceRequest is true).

This param will be conditionally false:

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js

Line 237 in 3d99502

true,

...
!isDistanceRequest,
...

This will make sure user can invite individuals only when the request is not a distance request.

What alternative solutions did you explore? (Optional)

We can also change the Text Input Label to show Workspace Name instead of the misleading Name, email, or phone number

[dukenv0307]

Proposal

Bring proposal from #27070 and update since MoneyRequestParticipantsSelector is updated to function component

Please re-state the problem that we are trying to solve in this issue.

The user account can be selected as participant for distance request

What is the root cause of that problem?

In MoneyRequestParticipantsSelector, We disable the P2P option here but we don't exclude the invited user for distance request

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js

Line 230 in d282473

!isDistanceRequest,

What changes do you think we should make in order to solve the problem?

In MoneyRequestParticipantsSelector, we should pass canInviteUser params as false here to exclude the invited user option for distance request.

const chatOptions = OptionsListUtils.getFilteredOptions(
    reports,
    personalDetails,
    betas,
    searchTerm,
    participants,
    CONST.EXPENSIFY_EMAILS,

    // If we are using this component in the "Request money" flow then we pass the includeOwnedWorkspaceChats argument so that the current user
    // sees the option to request money from their admin on their own Workspace Chat.
    iouType === CONST.IOU.TYPE.REQUEST,

    // We don't want to include any P2P options like personal details or reports that are not workspace chats for certain features.
    !isDistanceRequest,
    false,
    {},
    [],
    false,
    {},
    [],
    true,
    !isDistanceRequest,
);

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js

Line 230 in d282473

!isDistanceRequest,

OPTIONAL: We can update the placeholder of text input accordingly when the request is distance request

What alternative solutions did you explore? (Optional)

NA

Result

Screencast.from.07-09-2023.16.47.27.webm

[melvin-bot]

📣 @shahinyan11! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[Christinadobrzyn]

hi @cubuspl42 could you take a peek at the proposals to see if any will work?