[HOLD for payment 2023-10-30] [HOLD for payment 2023-10-27] [$500] Workspace - Crash when deleting a workspace

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.87.1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @bernhardoj
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697777999060829

Action Performed:

Prerequisite: have a workspace

1. Open the workspace #admins or #announce chat
2. Press the chat header to open the details
3. Press the workspace name below the chat name. You will be navigated to the workspace page.
4. Delete the workspace. You will be navigated back to the chat details.

Expected Result:

No crash happens

Actual Result:

After the user is navigated back to the chat details, the app crashed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Screen.Recording.2023-10-20.at.12.32.41.mov

Android: mWeb Chrome

Screen.Recording.2023-10-20.at.12.38.23.mov

iOS: Native

Screen.Recording.2023-10-20.at.12.37.51.mov

iOS: mWeb Safari

Screen.Recording.2023-10-20.at.12.39.09.mov

MacOS: Chrome / Safari

Screen.Recording.2023-10-20.at.12.26.03.mov

Recording.5089.mp4

MacOS: Desktop

Screen.Recording.2023-10-20.at.12.39.36.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01da3b9ed2ccdd9252
• Upwork Job ID: 1715358049654792192
• Last Price Increase: 2023-10-20
• Automatic offers:
• fedirjh | Reviewer | 27294854
• bernhardoj | Contributor | 27294856
• bernhardoj | Reporter | 27294858

[kbecciv]

Proposal by: @bernhardoj
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697777999060829

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes after deleting a workspace if we open it from the report details page.

What is the root cause of that problem?

When we successfully delete a workspace, the BE response will return an onyx data to set the deleted policy to null. Because the policy data is null, we got an error when trying to access its id property here (which is being used in the report details page).

App/src/libs/PolicyUtils.js

Line 164 in 732d48e

const isPolicyMember = (policyID, policies) => _.some(policies, (policy) => policy.id === policyID);

looks like Onyx initially sent the null policy to the subscriber, but after we refresh, the null policy is removed from the collection
This issue happens after #27966 where isPolicyMember is first introduced.

What changes do you think we should make in order to solve the problem?

We need to safely access the id using lodashGet

lodashGet(policy, 'id') === policyID

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @dangrous (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[dangrous]

Lovely! I'll make this external and assign you @bernhardoj

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01da3b9ed2ccdd9252