[HOLD for payment 2023-10-27] [$500] Remove the selected participants from the search results in the split / group chat flow

[thienlnam]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: Version 1.3.83-1 (1.3.83-1)
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation: https://expensify.slack.com/archives/C05RECHFBEW/p1697553482299739

Action Performed:

Break down in numbered steps

1. From the global create menu, send a message or request money
2. Select a bunch of participants and then search for a user that is not in the list

Expected Result:

When you start searching, the selected participants should not show up unless they are part of the search results.
When the search text is empty, the selected participants should show up again

Actual Result:

Selected participants are always in the option list

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Yes, but it's confusing on smaller screens

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

https://files.slack.com/files-pri/T047TPA624F-F061DSHBHAS/screenshot_2023-10-17_at_3.55.35_pm.png

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016fdba16a8b2fba60
• Upwork Job ID: 1714445993688682496
• Last Price Increase: 2023-10-18
• Automatic offers:
• abdulrahuman5196 | Reviewer | 27519943
• dukenv0307 | Contributor | 27519945

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[thienlnam]

Waiting to add external until we confirm this is the desired functionality https://expensify.slack.com/archives/C05RECHFBEW/p1697553482299739

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove the selected participants from the search results in the split / group chat flow

What is the root cause of that problem?

We always pass selected participants to the options selector here:

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js

Lines 107 to 115 in 8bc86cc

	newSections.push({
	title: undefined,
	data: _.map(participants, (participant) => {
	const isPolicyExpenseChat = lodashGet(participant, 'isPolicyExpenseChat', false);
	return isPolicyExpenseChat ? OptionsListUtils.getPolicyExpenseReportOption(participant) : OptionsListUtils.getParticipantsOption(participant, personalDetails);
	}),
	shouldShow: true,
	indexOffset,
	});

Once selected, the option will always appear.
We have to make sure the selected participants react to the searchTerm.

What changes do you think we should make in order to solve the problem?

We need to:

• Show selected participants on top of list when search is empty. We will exclude them from other sections
• When search is not empty we want to also search the selectedParticipants (and show them on top of the list)

We will be modifying the behaviour of the this section to filter according to searchTerm:

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js

Lines 107 to 115 in f626744

	newSections.push({
	title: undefined,
	data: _.map(participants, (participant) => {
	const isPolicyExpenseChat = lodashGet(participant, 'isPolicyExpenseChat', false);
	return isPolicyExpenseChat ? OptionsListUtils.getPolicyExpenseReportOption(participant) : OptionsListUtils.getParticipantsOption(participant, personalDetails);
	}),
	shouldShow: true,
	indexOffset,
	});

We will filter out participants when searchTerm is not empty.

data: _.chain(participants)
        .filter((participant) => searchTerm === '' || participant.searchText.includes(searchTerm))
        .map((participant) => { 
            const isPolicyExpenseChat = lodashGet(participant, 'isPolicyExpenseChat', false);
            return isPolicyExpenseChat ? OptionsListUtils.getPolicyExpenseReportOption(participant) : OptionsListUtils.getParticipantsOption(participant, personalDetails);       
        })
        .value(),

Before mapping the participants, we will filter them by checking the presence of searchTerm in searchText key for participants.

Result:

Screencast.from.18-10-23.07.38.24.AM.IST.webm

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016fdba16a8b2fba60