[HOLD for payment 2023-11-09] [$500] Same page has different error text color for different errors

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.85-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697540779491219

Action Performed:

1. Open the app
2. Click on plus and click on request money
3. In manual, without typing any numbers, click next
4. Observe error text color is red
5. Switch to distance and without selecting any waypoint, click next
6. Observe that error text color is white

Expected Result:

App should maintain same error text color on same pages

Actual Result:

App displays manual request money errors in red but distance errors in white even though they are on same RHN page

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android.native.same.page.different.error.color.mp4

Android: mWeb Chrome

Android.chrome.same.page.different.error.color.mp4

iOS: Native

ios.native.same.page.different.error.color.mov

iOS: mWeb Safari

ios.safari.same.page.different.error.color.mov

MacOS: Chrome / Safari

mac.chrome.same.page.different.error.colors.mov

Recording.112.mp4

MacOS: Desktop

mac.desktop.same.page.different.error.color.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f1225cd87883fded
• Upwork Job ID: 1714343355796758528
• Last Price Increase: 2023-10-17
• Automatic offers:
• Victor-Nyagudi | Contributor | 27357473
• dhanashree-sawant | Reporter | 27357475

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f1225cd87883fded

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[saranshbalyan-1234]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Same page has different error text color for different errors

What is the root cause of that problem?

We are using different components to show error.
for example

App/src/components/DistanceRequest/index.js

Lines 227 to 233 in 75a2cc9

	{((hasError && _.size(validatedWaypoints) < 2) || hasRouteError) && (
	<DotIndicatorMessage
	style={[styles.mh4, styles.mv3]}
	messages={getError()}
	type="error"
	/>
	)}

App/src/pages/iou/steps/MoneyRequestAmountForm.js

Lines 265 to 271 in cc6a1e3

	{!_.isEmpty(formError) && (
	<FormHelpMessage
	style={[styles.ph5]}
	isError
	message={translate(formError)}
	/>
	)}

What changes do you think we should make in order to solve the problem?

We can either use DotIndicatorMessage component in both the places
the solution would look something like this

    {!_.isEmpty(formError) && (
                    <DotIndicatorMessage
                        style={[styles.mh4, styles.mv3]}
                        messages={translate(formError)}
                        type="error"
                    />
                )}

What alternative solutions did you explore? (Optional)

We can also use FormHelpMessage compoenent in both the places
the solution would look something like this

    {((hasError && _.size(validatedWaypoints) < 2) || hasRouteError)  && (
                <FormHelpMessage
                    style={[styles.ph5]}
                    isError
                    message={getError()}
                />
            )}

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[abdel-h66]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistent error message styling between the distance request page and the manual request pages.

What is the root cause of that problem?

In the manual request page we use a component called FormHelpMessage that has the red dot and a white text when it's an error. But on the Distance page we are currently using another component called DotIndicatorMessage.

What changes do you think we should make in order to solve the problem?

In the MoneyRequestAmountForm we can display use the DotIndicatorMessage to have the same styling

<DotIndicatorMessage
       style={[styles.ph5]}
       messages={{0: formError}}
       type="error"
/>

What alternative solutions did you explore? (Optional)

Depending on which one should be the standard look, there is also the option of using FormHelpMessage in the distance request page, but I personally prefer to keep using the DotIndicatorMessage component, as it's used in many other forms.

DotIndicator.mp4

N/A

[Victor-Nyagudi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Same page has different error text color for different errors

What is the root cause of that problem?

The error shown during a manual money request flow is from FormHelpMessage component while the one shown during a distance request comes from DotIndicatorMessage.

The manual money request error text is set to red by styles.formError.

App/src/styles/styles.ts

Lines 1193 to 1194 in 9d79fd1

	formError: {
	color: theme.textError,

App/src/styles/themes/default.ts

Line 53 in 9d79fd1

textError: colors.red,

The distance request error text, however, is set to light greyish-green by styles.offlineFeedback.text.

App/src/styles/styles.ts

Lines 2871 to 2872 in 9d79fd1

	text: {
	color: theme.textSupporting,

App/src/styles/themes/default.ts

Line 19 in 9d79fd1

textSupporting: colors.darkSupportingText,

App/src/styles/colors.js

Line 21 in 9d79fd1

darkSupportingText: '#AFBBB0',

What changes do you think we should make in order to solve the problem?

I propose setting the text color to red (same as the one in manual money request error, for consistency's sake) in DotIndicatorMessage by changing the color property if props.type is equal to error.

style={[styles.offlineFeedback.text, props.type === 'error' && {color: styles.formError.color}]}

This prop is also what we're currently using to determine the color of the dot indicator (line 60).

App/src/components/DotIndicatorMessage.js

Lines 58 to 61 in 9d79fd1

	<Icon
	src={Expensicons.DotIndicator}
	fill={props.type === 'error' ? themeColors.danger : themeColors.success}
	/>

The duplicate error check could potentially be extracted to a variable like hasError and used in both places to keep the code DRY.

Short video after making changes

expensify-distance-request-error-red.mov

What alternative solutions did you explore? (Optional)

I was genuinely curious why the error text in a distance request was made light greyish-green in the first place whereas the other errors I've seen so far have been red.

I replaced the style property of the text in DotIndicatorMessage to be style={styles.formError}, and this also worked fine.

Both styles.formError, currently used by FormHelpMessage, and styles.offlineFeedback.text, currently used by DotIndicatorMessage, adjust the font size (to the same value) and color.

The main difference is styles.formError also adjusts the line height and margin bottom while styles.offlineFeedback.text only adjusts the vertical text alignment in addition.

However, after further investigation, I discovered the light greyish-green text is most likely for success messages given the dot indicator has two colors - red for error, and green for success.

[Victor-Nyagudi]

Proposal

Updated