[$500] Invite - Incorrect email validation in Invite member to Workspace page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.84.7
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @tranvantoan-qn
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697474981265639

Action Performed:

1. Login to any account
2. Go to Account Settings.
3. Open any Workspace (or create a new one).
4. Click on Members >> Invite.
5. Type any email address that contains a comma.
6. Observed Behavior: The search results still display, instead of showing the label "Invalid email"

Expected Result:

It should show the "Invalid email" label, as it does on other pages, such as when searching for contacts to chat.

Actual Result:

The search results still display, instead of showing the label "Invalid email"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android.-.Native.1.mov

Android: mWeb Chrome

Android.-.Chrome.1.mov

iOS: Native

iOS.-.Native.1.MP4

iOS: mWeb Safari

iOS.-.Safari.MP4

MacOS: Chrome / Safari

MacOS.-.Safari.1.mov

MacOS.-.Chrome.1.mp4

Recording.5020.mp4

MacOS: Desktop

MacOS.-.Desktop.1.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0184a22b8db6bfd1d7
• Upwork Job ID: 1713983384060686336
• Last Price Increase: 2023-10-23
• Automatic offers:
• eh2077 | Contributor | 27436383
• tranvantoan-qn | Reporter | 27436387

Issue Owner

Current Issue Owner: @miljakljajic

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0184a22b8db6bfd1d7

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[RadoslavLazarov]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Invite - Incorrect email validation in Invite member to Workspace page

What is the root cause of that problem?

This is happening because the search supports multiple emails separated by commas:

What changes do you think we should make in order to solve the problem?

In WorkspaceInvitePage.js component we can import Str to validate each email

import Str from 'expensify-common/lib/str';

add email validation in useEffect():

App/src/pages/workspace/WorkspaceInvitePage.js

Line 101 in fe40f63

const hasInvalidEmail = emails[0] && emails.some(email => !Str.isValidEmail(email));

then wrap

App/src/pages/workspace/WorkspaceInvitePage.js

Line 102 in fe40f63

_.each(emails, (email) => {

with if statement:

if (!hasInvalidEmail) {
            _.each(emails, (email) => {

What alternative solutions did you explore? (Optional)

N/A

Screen.Recording.2023-10-17.at.0.14.22.mov

[eh2077]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Incorrect email validation in Invite member to Workspace page

What is the root cause of that problem?

The root cause of this issue is that we treat searchTerm as a multiple keyword input separated by comma, see here. But when determining the header message, we handle searchTerm as a single keyword, see headerMessage.
For example, we have a search term like

test@gmail,com

We convert it into keywords, ['test@gmail', 'com'], and search each keyword to check if it matches name, email or phone of existing participantsList as the input label indicates, see here and getParticipantNames. If a keyword doesn't match existing participantsList and it's a valid format of an email or a phone number, then we consider it's a new user to invite, see here.

The second keyword, com, always match selection options. So headerMessage is empty.

What changes do you think we should make in order to solve the problem?

Based on the RCA above, we find that the search input feature is quite flexible comparing to the way we format header message. I think we can consider to refrain from enabling the multiple keywords feature in a single search term for the following reasons

1. Disabling it won't impact the overall function of search feature. The function OptionsListUtils.getMemberInviteOptions is already powerful enough to search options.
2. Avoid ambiguity. Processing a keyword per input improve the consistency between searching result and handling header message.
3. It also reduce the complexity to handle the searching. There're many edges need to be solved when treating a search term as a multiple-keyword input.

We can change this useEffect to let it treat searchTerm as a single search keyword.

What alternative solutions did you explore? (Optional)

Continue context from the main proposal, if we want to keep the multi-keyword feature of searchTerm, we need to add some constraints to search term includes comma to clarify the expected input and output. For example, we can require that

1. All keywords(converted from searchTerm) should be valid emails or phone numbers
2. Or except the last keyword
   We can further discuss it with the team to determine the rule.

[miljakljajic]

@allroundexperts what are your thoughts on the above proposal?