[$125] mWeb/Chrome - Scan - Flash icon appears then disappears in Scan tab

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.83-1

Reproducible in staging?: Yes

Reproducible in production?: No. New feature on staging.

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to + > Request money > Scan
3. Give camera permission if not yet

Expected Result:

Depending on whether flash is supported, the flash icon should either appear or not appear at all

Actual Result:

When the Scan tab is first opened, the camera flash icon on the bottom right corner appears and then disappears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Bug6234478_1697117658906.Screen_Recording_20231012_200316_Chrome.mp4

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019c363d1d939d77a1
• Upwork Job ID: 1712523919628128256
• Last Price Increase: 2023-10-12

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Scan - Flash icon appears then disappears in Scan tab (Reproducible with mSafari as well).

What is the root cause of that problem?

We will show the flash if flash is available and make it invisible by decrease the opacity to zero in here when the flash is not available

App/src/pages/iou/ReceiptSelector/index.js

Lines 242 to 255 in 9b5f8c4

	<PressableWithFeedback
	accessibilityRole={CONST.ACCESSIBILITY_ROLE.BUTTON}
	accessibilityLabel={translate('receipt.flash')}
	style={[styles.alignItemsEnd, !isTorchAvailable && styles.opacity0]}
	onPress={toggleFlashlight}
	disabled={!isTorchAvailable}
	>
	<Icon
	height={32}
	width={32}
	src={Expensicons.Bolt}
	fill={isFlashLightOn ? themeColors.iconHovered : themeColors.textSupporting}
	/>
	</PressableWithFeedback>

Because isTorchAvailable has default value true, it will be visible first then disappeared after that after onTorchAvailability is fired.

What changes do you think we should make in order to solve the problem?

That's quite confused to make it visible and then disappears like that, we should handle the flash button like the way we handle it on our mobile side by only disabling it if we didn't have the permission or it's not available.
So we should remove !isTorchAvailable && styles.opacity0 from our flash button styles.
We can also consider change the default value of isTorchAvailable to false to prevent user press on that button while we're checking for permission.

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019c363d1d939d77a1

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)