[HOLD for payment 2023-10-25] [$250] Workspace - Display name for #announce room members in details page is cut off

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.81-4

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

Precondition: User A and B do not have display name (display name is email).

1. Go to staging.new.expensify.com
2. [User A] Create a workspace and invite User B.
3. [User B] Go to #announce room and click on the room header

Expected Result:

The display name for User A and B is not cut off

Actual Result:

The display name for User A and B is cut off

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6232988_1697027645425.20231011_195527.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013b93f9ecc21f556d
• Upwork Job ID: 1712142512040468480
• Last Price Increase: 2023-10-11
• Automatic offers:
• situchan | Contributor | 27149144
• ginsuma | Contributor | 27217842

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[akinwale]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Individual long display names are cut off for the #announce room members when viewing the details.

What is the root cause of that problem?

In ReportDetailsPage, we are using the DisplayNames component to show display names, which renders the DisplayNamesWithToolTip component.

The DisplayNamesWithToolTip component renders each display name in a DisplayNamesTooltipItem. The Text component used to show the display name text has a styles.pre definition set for the style, which prevents long text from wrapping.

However, it turns out that the reportName which should be #announce is meant to be displayed here (as seen in production).

What changes do you think we should make in order to solve the problem?

Set shouldUseFullTitle to also be true if the report is not a group chat. This will ensure #announce is displayed as the title. This should also probably be done for admin rooms.

-const shouldUseFullTitle = ReportUtils.isTaskReport(props.report);
+const shouldUseFullTitle = ReportUtils.isTaskReport(props.report) || ReportUtils.isAnnounceRoom(props.report);

There is a pending PR for determining if a report is a group chat.

Since the first 2 or 3 display names will be shown for group chats, long names will also need to be properly wrapped.

Either
Add a prop to the DisplayNames component which will be forwarded to the DisplayNamesWithToolTip and DisplayNamesTooltipItem components in order to conditionally add the styles.pre style. We can call this shouldWrapLongDisplayNames.

Or
Remove the styles.pre style from the Text in the DisplayNamesTooltipItem component.

What alternative solutions did you explore? (Optional)

None.

[ginsuma]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - Display name for #announce room members in details page is cut off

What is the root cause of that problem?

In this PR #28200, we removed shouldDisableSettings and changed the condition to use the full title.
From:

App/src/pages/ReportDetailsPage.js

Line 64 in d122a0d

const shouldUseFullTitle = !shouldDisableSettings || ReportUtils.isTaskReport(props.report);

To:

App/src/pages/ReportDetailsPage.js

Line 64 in c313a62

const shouldUseFullTitle = ReportUtils.isTaskReport(props.report);

What changes do you think we should make in order to solve the problem?

Take it back to the old condition.