[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [$500] The "Merchant" title and page briefly appear instead of the distance title and page

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on the "+" button or go to the expense room
2. Navigate to Request money > Distance
3. Select Start and Finish points and proceed with the request
4. Quickly go to the distance request detail page and click on “Merchant”

Expected Result:

The "Merchant" title and page should not be displayed even for a brief moment when requesting money for a distance

Actual Result:

The "Merchant" title and page are briefly shown instead of the distance page

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native - Emulator not working and didn't attach video
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop - missing since desktop is crashing

Version Number: 1.3.78-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.5.mp4

screen-recording-2023-10-05-at-14053-am_9He1v6uv.mp4

Screen.Recording.2023-10-05.at.1.56.17.AM.mov

Screen.Recording.2023-10-05.at.1.53.59.AM.mov

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696452613289539

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e052b456797c7dfb
• Upwork Job ID: 1710009572771434496
• Last Price Increase: 2023-10-05

Issue Owner

Current Issue Owner: @adelekennedy

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e052b456797c7dfb

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The "Merchant" title and page briefly appear instead of the distance title and page

What is the root cause of that problem?

We are not checking the transaction is distance or not to display the title accordingly

App/src/pages/EditRequestMerchantPage.js

Line 44 in 1eafc7d

title={translate('common.merchant')}

What changes do you think we should make in order to solve the problem?

We should add an extra prop to EditRequestMerchantPage like isDistanceRequest to know if the request is distance or not. Use this prop to display the title

const title = isDistanceRequest ? translate('common.distance') : translate('common.merchant')

And then on EditRequestPage page, we will pass isDistanceRequest prop into EditRequestMerchantPage

<EditRequestMerchantPage
    defaultMerchant={transactionMerchant}
    isDistanceRequest={TransactionUtils.isDistanceRequest(transaction)}
    onSubmit={(transactionChanges) => {
        // In case the merchant hasn't been changed, do not make the API request.
        if (transactionChanges.merchant.trim() === transactionMerchant) {
            Navigation.dismissModal();
            return;
        }
        editMoneyRequest({merchant: transactionChanges.merchant.trim()});
    }}
/>

What alternative solutions did you explore? (Optional)

NA

Result

Screencast.from.06-09-2023.22.03.00.webm

[neil-marcellini]

I've fixed this in #27204

Screen.Recording.2023-10-05.at.3.07.16.PM.mov