[HOLD for payment 2023-12-18] Web - Camera border color is different

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to settings > profile
2. Check the border color around the camera icon

Expected Result:

Border color should be match with background

Actual Result:

Border color is different

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.77.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694753216621329

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0120fb4ad1be8bb18b
• Upwork Job ID: 1709571217501925376
• Last Price Increase: 2023-10-25

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0120fb4ad1be8bb18b

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[gadhiyamanan]

Proposal

Please re-state the problem that we are trying to solve in this issue.

camera border color is different

What is the root cause of that problem?

We are using wrong borderColor

What changes do you think we should make in order to solve the problem?

Change borderColor from textReversed to componentBG and also we can remove the unwanted prop color

App/src/styles/styles.js

Lines 2685 to 2695 in db4d85b

	smallEditIcon: {
	alignItems: 'center',
	backgroundColor: theme.buttonHoveredBG,
	borderColor: theme.textReversed,
	borderRadius: 14,
	borderWidth: 3,
	color: theme.textReversed,
	height: 28,
	width: 28,
	justifyContent: 'center',
	},

[PiyushChandra17]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Border color is different

What is the root cause of that problem?

We are using incorrect borderColor here,

App/src/styles/styles.js

Line 2703 in 96c6c51

borderColor: theme.textReversed,

What changes do you think we should make in order to solve the problem?

Replace theme.textReversed with theme.appBG

smallEditIcon: {
        alignItems: 'center',
        backgroundColor: theme.buttonHoveredBG,
        borderColor: theme.appBG,
        borderRadius: 14,
        borderWidth: 3,
        color: theme.textReversed,
        height: 28,
        width: 28,
        justifyContent: 'center',
    }

What alternative solutions did you explore? (Optional)

NA

Result:

[teneeto]

Hi, I'm Eto from Callstack - expert contributor group - and I would like to take a look at this issue.