[WAITING ON CHECKLIST] [HOLD for payment 2023-10-23] [$500] Room - Division sign (÷) is working as the room name

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open App > Press FAB > Send message
2. Go To The Room tab
3. On room name input add division sign (÷)
4. Unfocused the room name input

Expected Result:

We should get the error Room names can only include lowercase letters, numbers and hyphens error, as the division sign is not the letter or number

Actual Result:

Not getting any error when adding the division sign and the division sign is working as a room name

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

**Version Number:**1.3.77.2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

mWeb-Android.mov

Android.mov

web-safari.1.mov

web-chrome.1.mov

mweb-safari.mov

iOS.mov

desktop.1.mov

Recording.4841.mp4

Expensify/Expensify Issue URL:
Issue reported by: @jayeshmangwani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696336839411529

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014079b4a0e4f3876d
• Upwork Job ID: 1709541008453763072
• Last Price Increase: 2023-10-04
• Automatic offers:
• 0xmiroslav | Contributor | 27107049
• jayeshmangwani | Reporter | 27107050

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014079b4a0e4f3876d

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[kbecciv]

Proposal by: @jayeshmangwani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696336839411529

Proposal

Please re-state the problem that we are trying to solve in this issue.

Entering division sign (÷) is not showing any error for the room name

What is the root cause of that problem?

We are using /^#[a-z0-9à-ÿ-]{1,80}$/ regex for validating the room name

App/src/CONST.ts

Line 1226 in 00933e1

ROOM_NAME: /^#[a-z0-9à-ÿ-]{1,80}$/,

To specific, checking the Latin character we are using this à-ÿ range, in the above regex

à-ÿ matches a single character in the range between à (index 224) and ÿ (index 255) (case sensitive)

so any character that has code in between 224 to 255 will be acceptable,

Divide sign character code is 247, (reference https://www.htmlhelp.com/reference/charset/iso224-255.html ) that's why its valid character per the used regex

What changes do you think we should make in order to solve the problem?

I would suggest that we need to update the ROOM_NAME regex to that use Latin Script unicode instead of à-ÿ range

\p{Ll} will include the all the latin characters in lowercase

- ROOM_NAME: /^#[a-z0-9à-ÿ-]{1,80}$/
+ ROOM_NAME: /^[\p{Ll}0-9-]{1,80}$/u

What alternative solutions did you explore? (Optional)

Either we can remove the à-ÿ range and rather we should pass the Spanish accents
á, é, í, ó, ú, ñ, ü

then regex will look like this

    ROOM_NAME: /^#[a-z0-9áéíóúñü-]{1,80}$/

[jayeshmangwani]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Entering division sign (÷) is not showing any error for the room name

What is the root cause of that problem?

We are using /^#[a-z0-9à-ÿ-]{1,80}$/ regex for validating the room name

App/src/CONST.ts

Line 1226 in 00933e1

ROOM_NAME: /^#[a-z0-9à-ÿ-]{1,80}$/,

To specific, checking the Latin character we are using this à-ÿ range, in the above regex

à-ÿ matches a single character in the range between à (index 224) and ÿ (index 255) (case sensitive)

so any character that has code in between 224 to 255 will be acceptable,

Divide sign character code is 247, (reference https://www.htmlhelp.com/reference/charset/iso224-255.html ) that's why its valid character per the used regex

What changes do you think we should make in order to solve the problem?

I would suggest that we need to update the ROOM_NAME regex to that use Latin Script unicode instead of à-ÿ range

\p{Ll} will include the all the latin characters in lowercase

- ROOM_NAME: /^#[a-z0-9à-ÿ-]{1,80}$/
+ ROOM_NAME: /^[\p{Ll}0-9-]{1,80}$/u

What alternative solutions did you explore? (Optional)

Either we can remove the à-ÿ range and rather we should pass the Spanish accents
á, é, í, ó, ú, ñ, ü

then regex will look like this

    ROOM_NAME: /^#[a-z0-9áéíóúñü-]{1,80}$/

[ayazalavi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Room name input letting characters other than lower case letters, numbers and hyphen

What is the root cause of that problem?

Root cause of the problem is in ROOM_NAME: /^#[a-z0-9à-ÿ-]{1,80}$/,

1. The regex is designed to match a string that starts with #. If you want to match lowercase letters, numbers, and hyphens anywhere in the string, you should remove the ^ and $ anchors at the beginning and end.

2. The range [à-ÿ] only covers characters in the Latin-1 Supplement block, which includes some accented characters used in Western European languages but not characters from all languages. To match lowercase letters from all languages, you should use the Unicode character class \p{Ll} instead.

What changes do you think we should make in order to solve the problem?

Here's an updated regex pattern that matches lowercase letters (in any language), numbers, and hyphens anywhere in the string, with a length between 1 and 80 characters:

/#[\p{Ll}0-9-]{1,80}/

This pattern matches a string that starts with # and is followed by a combination of lowercase letters (in any language), numbers, and hyphens, with a length between 1 and 80 characters.

What alternative solutions did you explore? (Optional)

N/A

[jliexpensify]

Can repro!