[HOLD for payment 2023-10-09] [$250] Personal Details - When random url param for country passed the app crashes on Dev and shows allCountries.randomParam

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to Settings -> personal Details -> Home Address ->
2. Select Country Selection, Choose a country
3. Change country param in URL to anything random

Expected Result:

Selected country should not change or fallback to default a default country

Actual Result:

Selected country changes to allCountries.randomParam

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.76.4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-10-03.at.3.34.20.AM.mov

RPReplay_Final1696355269.MP4

RPReplay_Final1696354866.MP4

Recording.4835.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ishpaul777
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696284209392199

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ad40bd8b7e5b3460
• Upwork Job ID: 1709296238434172928
• Last Price Increase: 2023-10-06

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ad40bd8b7e5b3460

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[saranshbalyan-1234]

Proposal

Please re-state the problem that we are trying to solve in this issue.

While changing the country code from URL in the address page, it shows unwanted string instead of country

What is the root cause of that problem?

App/src/components/CountrySelector.js

Line 38 in 6f3c706

const title = countryCode ? translate(`allCountries.${countryCode}`) : '';

The issue is here as we are only checking if the country code is present, we also have to check whether the provided country code is in country list.

What changes do you think we should make in order to solve the problem?

we also have to check whether the provided country code is in country list in constants from this

App/src/CONST.ts

Lines 1465 to 1469 in d913865

	ALL_COUNTRIES: {
	AF: 'Afghanistan',
	AX: 'Åland Islands',
	AL: 'Albania',
	DZ: 'Algeria',

The result would look something like this

  const title = isCountryCodeExist && countryCode ? translate(`allCountries.${countryCode}`) : '';

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[kbecciv]

Proposal by: @ishpaul777
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696284209392199

Proposal

Problem

When there is a invalid url param for country is passed, the selected country is shown as "allCountries.randommparampassed" and in dev environment, app crashes.

Root cause

The root cause is that the country param is not validated before setting the current country in the AddressPage, and invalid country param is passed to the CountrySelector, as the param is invalid, the country is not found in the country list translation, and title is set to "allCountries.randommparampassed", In dev environment, app crashes as the country is not found in the country list.

Solution

we need to validate the country param before setting the current country in the AddressPage, and if the country is invalid, we will not set the current country here.

const isCountryFromUrlValid = lodashGet(CONST.ALL_COUNTRIES, countryFromUrl);
if (!countryFromUrl || countryFromUrl === currentCountry || !isCountryFromUrlValid)

Optionally we can set error message in the CountrySelector if the country is invalid, so that user can know that the country is invalid.
or we can show a Not Found page if the country param is invalid.

[DylanDylann]

Could we consider this is regression from #26742 ?

[stephanieelliott]

Could we consider this is regression from #26742 ?

Hey @allroundexperts what do you think?