[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] Web - Request - User avatar from WS chat avatar is removed after returning from confirmation page

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com
2. Go to + > Request money > Distance.
3. Select address for Start and Finish point.
4. Click Next.
5. Select a workspace.
6. Return to the previous page.
   Note that the user avatar on the bottom right of workspace avatar is gone.

Expected Result:

The stacked avatars (workspace avatar with user avatar) for the selected workspace chat remain unchanged.

Actual Result:

User avatar in the stacked avatars for workspace chat disappears.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.76-6

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6223432_1696347280505.20231003_233154.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015f6eb6d95d865c8f
• Upwork Job ID: 1709236968325705728
• Last Price Increase: 2023-10-03
• Automatic offers:
• alitoshmatov | Contributor | 27109750

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015f6eb6d95d865c8f

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[abdel-h66]

Proposal

Please re-state the problem that we are trying to solve in this issue.

User avatar from WS disappears after selecting a split bill in the WS

What is the root cause of that problem?

To display the list of users or workspaces included we use

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js

Lines 112 to 120 in e30dce1

	newSections.push({
	title: undefined,
	data: _.map(participants, (participant) => {
	const isPolicyExpenseChat = lodashGet(participant, 'isPolicyExpenseChat', false);
	return isPolicyExpenseChat ? OptionsListUtils.getPolicyExpenseReportOption(participant) : OptionsListUtils.getParticipantsOption(participant, personalDetails);
	}),
	shouldShow: true,
	indexOffset,
	});

And then we call getPolicyExpenseReportOption

App/src/libs/OptionsListUtils.js

Lines 99 to 114 in e30dce1

	function getPolicyExpenseReportOption(report) {
	const expenseReport = policyExpenseReports[`${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`];
	const policyExpenseChatAvatarSource = ReportUtils.getWorkspaceAvatar(expenseReport);
	const reportName = ReportUtils.getReportName(expenseReport);
	return {
	...expenseReport,
	keyForList: expenseReport.policyID,
	text: reportName,
	alternateText: Localize.translateLocal('workspace.common.workspace'),
	icons: [
	{
	source: policyExpenseChatAvatarSource,
	name: reportName,
	type: CONST.ICON_TYPE_WORKSPACE,
	},
	],

While for all the sections we use getIcons that correctly performs many checks to return the correct icon or icons if possible.

What changes do you think we should make in order to solve the problem?

We can update getPolicyExpenseReportOption to use the getIcons function and we should be able to get a consistent display of icons.

    return {
....
        icons: ReportUtils.getIcons(report, personalDetails, UserUtils.getAvatar(personalDetail.avatar, personalDetail.accountID), personalDetail.login, personalDetail.accountID),
....
    };

Results

What alternative solutions did you explore? (Optional)

N/A

[alitoshmatov]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Distance - User avatar from WS chat avatar is removed after returning from confirmation page

What is the root cause of that problem?

The root cause is that options are not generated consistently in the same form.
When generating initial options which is in Recent section in participants list we use OptionsListUtils.getFilteredOptions which in turn uses createOption function

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js

Line 221 in 3b06da5

const chatOptions = OptionsListUtils.getFilteredOptions(

And this is the case everywhere for providing OptionsSelector with options we use createOption function to generate individual options.

But, here we are using OptionsListUtils.getPolicyExpenseReportOption function which is not generating option object in the same structure.

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js

Line 116 in 3b06da5

return isPolicyExpenseChat ? OptionsListUtils.getPolicyExpenseReportOption(participant) : OptionsListUtils.getParticipantsOption(participant, personalDetails);

App/src/libs/OptionsListUtils.js

Lines 99 to 119 in 0c49b11

	function getPolicyExpenseReportOption(report) {
	const expenseReport = policyExpenseReports[`${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`];
	const policyExpenseChatAvatarSource = ReportUtils.getWorkspaceAvatar(expenseReport);
	const reportName = ReportUtils.getReportName(expenseReport);
	return {
	...expenseReport,
	keyForList: expenseReport.policyID,
	text: reportName,
	alternateText: Localize.translateLocal('workspace.common.workspace'),
	icons: [
	{
	source: policyExpenseChatAvatarSource,
	name: reportName,
	type: CONST.ICON_TYPE_WORKSPACE,
	},
	],
	selected: report.selected,
	isPolicyExpenseChat: true,
	searchText: report.searchText,
	};
	}

What changes do you think we should make in order to solve the problem?

We should fix OptionsListUtils.getPolicyExpenseReportOption function, so that it also generates option object in the same structure. We can use createOption function here similar to this:

    const detailedReport= ReportUtils.getReport(report.reportID)
    return createOption(detailedReport.participantAccountIDs, allPersonalDetails, detailedReport, {}, {
        showChatPreviewLine: false,
        forcePolicyNamePreview: false
    })

We also need to retrieve detailed report since report object provided in argument is not complete

What alternative solutions did you explore? (Optional)

[DylanDylann]

@abdel-h66 I see there are some other function that don't use getIcons function like getParticipantsOption, getIOUConfirmationOptionsFromPayeePersonalDetail. In case, your proposal is approved, we can consider fixing these function, too.