[HOLD for payment 2023-10-30] [$500] Chat - Another report is displayed when access the report detail page by deep link

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open a report
2. Send a message
3. Create a workspace
4. Go to the announce chat room
5. Click on header to open detail page
6. Copy the URL
7. Logout and login again with this URL
8. Notice the report screen is displayed

Expected Result:

The report screen should display the report that matches with reportID param in the URL

Actual Result:

The detail page is the detail page of announce room but the report screen displays another report

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• MacOS / Chrome / Safari
• Windows / Chrome
• MacOS / Desktop

Version Number: 1.3.76-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional
https://github.com/Expensify/App/assets/78819774/8b0bee74-b1a7-4a7e-8bf9-7c9125b2f7bb

Screencast.from.02-10-2023.14_13_36.webm

Recording.128.mp4

Expensify/Expensify Issue URL:

Issue reported by: @dukenv0307

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696230613828629

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e25fea022af2f13a
• Upwork Job ID: 1708911256957870080
• Last Price Increase: 2023-10-16
• Automatic offers:
• hoangzinh | Reviewer | 27234356
• dukenv0307 | Contributor | 27234359
• dukenv0307 | Reporter | 27234362

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e25fea022af2f13a

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[lanitochka17]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Another report is displayed when access the report detail page by deep link

What is the root cause of that problem?

In getLastAccessedReportID function, we only return the current reportID in route if it's an attachment URL. So when we open the other sub-report URL this will return the last active report of the user

App/src/libs/Navigation/AppNavigator/ReportScreenIDSetter.js

Lines 62 to 65 in 2160bab

	const getLastAccessedReportID = (reports, ignoreDefaultRooms, policies, isFirstTimeNewExpensifyUser, openOnAdminRoom) => {
	// If deeplink url is of an attachment, we should show the report that the attachment comes from.
	const currentRoute = Navigation.getActiveRoute();
	const matches = CONST.REGEX.ATTACHMENT_ROUTE.exec(currentRoute);

What changes do you think we should make in order to solve the problem?

We should use ReportUtils.parseReportRouteParams function to get reportID in the param from the route and return it if exists

const getLastAccessedReportID = (reports, ignoreDefaultRooms, policies, isFirstTimeNewExpensifyUser, openOnAdminRoom) => {
    // If deeplink url contains reportID params, we should show the report that has this reportID.
    const currentRoute = Navigation.getActiveRoute();
    const { reportID } = ReportUtils.parseReportRouteParams(currentRoute);
    console.log(reportID);
    if (reportID) {
        return reportID;
    }
    const lastReport = ReportUtils.findLastAccessedReport(reports, ignoreDefaultRooms, policies, isFirstTimeNewExpensifyUser, openOnAdminRoom);
    return lodashGet(lastReport, 'reportID');
};

App/src/libs/Navigation/AppNavigator/ReportScreenIDSetter.js

Lines 62 to 65 in 2160bab

	const getLastAccessedReportID = (reports, ignoreDefaultRooms, policies, isFirstTimeNewExpensifyUser, openOnAdminRoom) => {
	// If deeplink url is of an attachment, we should show the report that the attachment comes from.
	const currentRoute = Navigation.getActiveRoute();
	const matches = CONST.REGEX.ATTACHMENT_ROUTE.exec(currentRoute);

What alternative solutions did you explore? (Optional)

NA

Result

Screencast.from.02-10-2023.14.34.22.webm

[hoangzinh]

@dukenv0307 Thanks for your proposal. I think your RCA is not really correct. Before we jump to the getLastAccessedReportID function, we already checked the reportID in the route here

App/src/libs/Navigation/AppNavigator/ReportScreenIDSetter.js

Lines 81 to 85 in b1b8bd7

	// Don't update if there is a reportID in the params already
	if (lodashGet(route, 'params.reportID', null)) {
	App.confirmReadyToOpenApp();
	return;
	}

Could you help to investigate the root cause again? Thanks

[hoangzinh]

@lanitochka17 it seems you missed clarifying it is a proposal of @dukenv0307 in this comment #28641 (comment), isn't it?

[dukenv0307]

Thanks for your proposal. I think your RCA is not really correct. Before we jump to the getLastAccessedReportID function, we already checked the reportID in the route here

@hoangzinh We already checked the reportID in the route but after signing the route doesn't contain reportID param. That is the reason in getLastAccessedReportID, we check the reportID in attachment route

Because the deep link is RightModalNavigator screen but ReportScreen is CentralPaneNavigator, it has initialParams here

App/src/libs/Navigation/AppNavigator/Navigators/CentralPaneNavigator.js

Line 21 in 7f063c7

initialParams={{openOnAdminRoom: openOnAdminRoom ? 'true' : undefined}}