[HOLD for payment 2023-10-16] [$500] Log in - App doesn't switches to first digit on click on didn't recieved a magic code click

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. If login then logout
3. Enter any contact and continue
4. Shift focus to any other digit then 1st digit and wait for some time to enable 'Didn't recieved a magic code' link
5. when enabled, click on it and observe that app doesn't reset to first digit

Expected Result:

App should reset focus to first digit on click on 'Didn't recieved a magic code' link

Actual Result:

App doesn't reset focus to first digit on click on 'Didn't recieved a magic code' link

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.75-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

focus.does.not.go.to.first.digit.IOS.safari.1.mov

focus.does.not.get.back.to.first.digit.IOS.1.mov

focus.does.not.go.to.first.digit.mac.desktop.1.mov

focus.does.not.shift.to.first.digit.windows.chrome.1.mp4

android.chrome.focus.does.not.go.back.to.first.digit.1.mp4

0-02-01-5b5124654b336a88428c096bca2af934fe7cd8de0c4396514a036a7976d572e2_c299dac93520f303.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: @dhanashree-sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695578315038989

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019251bb2b1418cd16
• Upwork Job ID: 1708239064011689984
• Last Price Increase: 2023-09-30
• Automatic offers:
• aimane-chnaif | Reviewer | 26989941

Issue Owner

Current Issue Owner: @anmurali

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019251bb2b1418cd16

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue

App doesn't reset focus to first field on click on reset link

What is the root cause of that problem?

After resend we don't update focus state

What changes do you think we should make in order to solve the problem?

We can add inputValidateCodeRef.current.focus() inside resendValidateCode

App/src/pages/signin/ValidateCodeForm/BaseValidateCodeForm.js

Lines 178 to 182 in 7c86d09

	const resendValidateCode = () => {
	User.resendValidateCode(props.credentials.login);
	// Give feedback to the user to let them know the email was sent so that they don't spam the button.
	setTimeRemaining(30);
	};

What alternative solutions did you explore? (Optional)

NA

Screen.Recording.2023-10-01.at.00.27.31.mov

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App doesn't switch to the first digit when clicked on didn't receive a magic code link.

What is the root cause of that problem?

We're not resetting the state of the magic code input when clicked on the link as seen here.

What changes do you think we should make in order to solve the problem?

We should reset the inputValidateCodeRef state here and add the following:

        setValidateCode('');
        inputValidateCodeRef.current.clear();
        inputValidateCodeRef.current.focus();

This is in sync with how we're handling this here.

We might also encapsulate this functionality which is common across the two components into another common component and DRY the code a bit.

What alternative solutions did you explore? (Optional)

None

[aimane-chnaif]

@allroundexperts's proposal looks good to me.
🎀 👀 🎀 C+ reviewed