[HOLD for payment 2023-10-13] [$500] Chat - App does not allow pasting number if numbers has comma in end for english and vice versa

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any report
3. If language is English, write any number and write full stop in the end and copy it eg: '2000.'
4. Paste text in plus->request money and observe that it allows to paste the text
5. Similarly try copy number with comma in middle and observe that app allows to paste
6. Similarly, try copy number with comma in end and observe that now app does not allow to paste the number
7. If language is Spanish, follow all the above steps just use full stop in place of comma

Expected Result:

App should allow copy pasting number in request money with comma in end as it allows copy paste of number with comma in middle or copy paste of number with full stop in end (English language)

Actual Result:

App does not allow copy pasting number in request money with comma in end for English language and it doesn't allow copy paste number with full stop in end for Spanish language

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.74-2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation:

windows.chrome.comma.or.fullstop.in.english.or.spanish.in.end.does.not.paste.amount.mp4

Recording.115.mp4

android.native.does.not.allow.to.paste.numbers.with.comma.1.mp4

Ipste.mp4

Ipse2.mp4

Expensify/Expensify Issue URL:

Issue reported by: @dhanashree-sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695835603519559

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017fcdbf8f05309fae
• Upwork Job ID: 1708219578554970112
• Last Price Increase: 2023-09-30
• Automatic offers:
• Ollyws | Reviewer | 26999991
• c3024 | Contributor | 26999997
• dhanashree-sawant | Reporter | 26999998

[c3024]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pasting amount like 20, is not shown in the new request amount page.

What is the root cause of that problem?

We are using this regex here

App/src/libs/MoneyRequestUtils.ts

Lines 45 to 48 in bfda42d

	function validateAmount(amount: string): boolean {
	const decimalNumberRegex = new RegExp(/^\d+(,\d+)*(\.\d{0,2})?$/, 'i');
	return amount === '' || (decimalNumberRegex.test(amount) && calculateAmountLength(amount) <= CONST.IOU.AMOUNT_MAX_LENGTH);
	}

to validate the amount and this regex requires at least a digit to be followed by comma to be valid.
If the amount is not valid it just sets the previous amount.

What changes do you think we should make in order to solve the problem?

I think since we are allowing 20. as valid it is reasonable to allow 20, also as valid.
Regex for this would be

const decimalNumberRegex = new RegExp(/^\d+(,\d*)?(\.\d{0,2})?$/, 'i');

This accepts 20, but disallows 20,,, this is in line with the present regex allowing 20. but not 20...
We can change the regex if we need a different vaidation

What alternative solutions did you explore? (Optional)

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017fcdbf8f05309fae

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App does not allow pasting number if numbers has comma in end for english and vice versa.

What is the root cause of that problem?

The root cause of the problem lies in the regular expression used for validation. The current regex pattern doesn't account for numbers that end with a comma.

App/src/libs/MoneyRequestUtils.ts

Line 46 in bfda42d

const decimalNumberRegex = new RegExp(/^\d+(,\d+)*(\.\d{0,2})?$/, 'i');

What changes do you think we should make in order to solve the problem?

To address this issue, we should update the regular expression used for number validation to accommodate numbers with a trailing comma.

const decimalNumberRegex = new RegExp(/^\d+(,\d+)*(\.\d{0,2})?,?$/, 'i');

Result

[Ollyws]

@c3024 @Krishna2323 Thanks for the proposals, modifying this regex works but can either of you tell me why pasting a trailing comma works for when the language is set to English but not to Spanish?

[c3024]

, and . are interchanged in Spanish. So we can paste 20, in Spanish but not 20. @Ollyws