[HOLD for payment 2023-11-29] [$500] Inconsistency bug - Assign Task - Task description does not remove empty quotes (works fine in private notes)

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open task report or assign any user task and open the report
3. Open description
4. Enter text with multiple empty quotes eg:

> Hello
>
>

6. Save the description and observe that description displays only one quote with text on task page (which is correct)
7. Again open description and observe that extra greater then signs are not removed
8. Paste similar text in composer, send and edit and observe that extra greater then signs are removed
9. Similarly try the text in private notes of any user and observe that private notes too removes the extra signs

Expected Result:

App should remove greater then signs with no text after it when description is saved like we do throughout the app

Actual Result:

App does remove greater then signs with no text after it when description is saved in task

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.74-2

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

mac.chrome.desktop.description.is.not.resolved.1.mov

Screen_Recording_20230928_152004_New.Expensify.mp4

Ios.Safari.Native.Description.Is.Not.Resolved.1.mp4

android.chrome.description.is.not.fixed.for.quotes.mp4

mac.chrome.desktop.description.is.not.resolved.mov

Recording.1663.mp4

Expensify/Expensify Issue URL:

Issue reported by: @dhanashree-sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695746974925629

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cbe475b72eea075d
• Upwork Job ID: 1707098020774612992
• Last Price Increase: 2023-09-27
• Automatic offers:
• DylanDylann | Contributor | 27099861
• dhanashree-sawant | Reporter | 27099863

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01cbe475b72eea075d

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

[saranshbalyan-1234]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In task description data is not trimmed

What is the root cause of that problem?

While saving task description we are not trimming the description here.

App/src/pages/tasks/TaskDescriptionPage.js

Lines 46 to 53 in f596e35

	const submit = useCallback(
	(values) => {
	// Set the description of the report in the store and then call Task.editTaskReport
	// to update the description of the report on the server
	Task.editTaskAndNavigate(props.report, props.session.accountID, {description: values.description});
	},
	[props],
	);

and

App/src/pages/tasks/NewTaskDescriptionPage.js

Lines 64 to 67 in f596e35

	const onSubmit = (values) => {
	Task.setDescriptionValue(values.taskDescription);
	Navigation.goBack(ROUTES.NEW_TASK);
	};

What changes do you think we should make in order to solve the problem?

We need to trim the data before saving like this in TaskDescriptionPage

  const submit = useCallback(
        (values) => {
            // Set the description of the report in the store and then call Task.editTaskReport
            // to update the description of the report on the server
             const editedDescription = parser.replace( values.description.trim());
            Task.editTaskAndNavigate(props.report, props.session.accountID, {description: editedDescription});
        },
        [props],
    );

and in NewTaskDescriptionPage

   const onSubmit = (values) => {
        const editedDescription = parser.replace( values.description.trim());
        Task.setDescriptionValue(editedDescription);
        Navigation.goBack(ROUTES.NEW_TASK);
    };

What alternative solutions did you explore? (Optional)

N/A

[yh-0218]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistency bug - Assign Task - Task description does not remove empty quotes

What is the root cause of that problem?

Because we save origin description (user input).
Ex. > Test \n >
We need to update this to > Test before we save using ExpensiMark

App/src/pages/tasks/TaskDescriptionPage.js

Lines 46 to 53 in f596e35

	const submit = useCallback(
	(values) => {
	// Set the description of the report in the store and then call Task.editTaskReport
	// to update the description of the report on the server
	Task.editTaskAndNavigate(props.report, props.session.accountID, {description: values.description});
	},
	[props],
	);

and

App/src/pages/tasks/NewTaskDescriptionPage.js

Lines 64 to 67 in f596e35

	const onSubmit = (values) => {
	Task.setDescriptionValue(values.taskDescription);
	Navigation.goBack(ROUTES.NEW_TASK);
	};

What changes do you think we should make in order to solve the problem?

For TaskDescriptionPage, we need save updatedDescription instead of values.description.

            const parser = new ExpensiMark();
            const editedDescription = parser.replace(values.description.trim());
            const updatedDescription = parser.htmlToMarkdown(editedDescription);
            Task.editTaskAndNavigate(props.report, props.session.accountID, {description: updatedDescription});

For NewTaskDescriptionPage, we need save updatedDescription instead of values.taskDescription.

            const parser = new ExpensiMark();
            const editedDescription = parser.replace(values.taskDescription.trim());
            const updatedDescription = parser.htmlToMarkdown(editedDescription);
            Task.setDescriptionValue(updatedDescription); 
            Navigation.goBack(ROUTES.NEW_TASK); 

What alternative solutions did you explore? (Optional)

[yurakurets]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Description text is saving just as plain text, while it can be displayed as markdown.

What is the root cause of that problem?

There are 3 steps where it happens:

1. When user starts creating task

App/src/pages/tasks/NewTaskDetailsPage.js

Lines 64 to 70 in f596e35

	// On submit, we want to call the assignTask function and wait to validate
	// the response
	function onSubmit(values) {
	Task.setDetailsValue(values.taskTitle, values.taskDescription);
	Navigation.navigate(ROUTES.NEW_TASK);
	}

2. On the second step of creating

App/src/pages/tasks/TaskDescriptionPage.js

Lines 46 to 53 in f596e35

	const submit = useCallback(
	(values) => {
	// Set the description of the report in the store and then call Task.editTaskReport
	// to update the description of the report on the server
	Task.editTaskAndNavigate(props.report, props.session.accountID, {description: values.description});
	},
	[props],
	);

3. When user edits task description

App/src/pages/tasks/TaskDescriptionPage.js

Lines 45 to 54 in f596e35

	const submit = useCallback(
	(values) => {
	// Set the description of the report in the store and then call Task.editTaskReport
	// to update the description of the report on the server
	Task.editTaskAndNavigate(props.report, props.session.accountID, {description: values.description});
	},
	[props],
	);

What changes do you think we should make in order to solve the problem?

We have to parse description field on each of these steps via ExpensiMark and save parsed version of it:

function onSubmit(values) {
        const parser = new ExpensiMark();
        const markdownDescription = parser.htmlToMarkdown(parser.replace(values.taskDescription.trim()))
        Task.setDetailsValue(values.taskTitle, markdownDescription);
        Navigation.navigate(ROUTES.NEW_TASK);
    }

const onSubmit = (values) => {
        const parser = new ExpensiMark();
        const markdownDescription = parser.htmlToMarkdown(parser.replace(values.taskDescription.trim()))
        Task.setDescriptionValue(markdownDescription);
        Navigation.goBack(ROUTES.NEW_TASK);
    };

    const submit = useCallback(
        (values) => {
            const parser = new ExpensiMark();
            const markdownDescription = parser.htmlToMarkdown(parser.replace(values.description.trim()))
            // Set the description of the report in the store and then call Task.editTaskReport
            // to update the description of the report on the server
            Task.editTaskAndNavigate(props.report, props.session.accountID, {description: markdownDescription});
        },
        [props],
    );

The last thing to take into account is the state of NewTaskDetailsPage.js const [taskDescription, setTaskDescription] = useState(props.task.description || '');, because there is an option to go back to this screen and then user will be able to see old state with empty quotes. In order to fix it we should update state on focus, currently it's syncing in useEffect

App/src/pages/tasks/NewTaskDetailsPage.js

Lines 44 to 48 in f596e35

	useEffect(() => {
	setTaskTitle(props.task.title);
	setTaskDescription(props.task.description || '');
	}, [props.task]);

    useEffect(() => {
        setTaskTitle(props.task.title);
    }, [props.task]);

    useFocusEffect(useCallback(() => {
        setTaskDescription(props.task.description || '');
    }, [props.task.description]))

Screen.Recording.2023-09-28.at.14.51.57.mov

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

📣 @yurakurets! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>