[$500] Request Money - Category edit page shown for normal money request (betweem 2 users)

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Create a money request with user (no workspace)
2. Go to that money request page
3. Append /edit/category to url
4. Category is visible

Expected Result:

Category shouldn't be shown for 1:1 money request, user should see page is not found with appropriate message

Actual Result:

Category edit page shown for normal money request (between 2 users)

Workaround

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.74.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-24.at.10.14.28.AM.mov

Recording.4767.mp4

Expensify/Expensify Issue URL:
Issue reported by: @BhuvaneshPatil
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695530860289029

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01445341bcc011416f
• Upwork Job ID: 1706399640115785728
• Last Price Increase: 2023-10-02

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01445341bcc011416f

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @dylanexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[RichardPickman]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Category modal opens in one-to-one money request when redirecting to /edit/category.

What is the root cause of that problem?

Modal opens whenever path satisfies mask /edit/category

What changes do you think we should make in order to solve the problem?

Add additional check on request type to open category list.

App/src/pages/EditRequestPage.js

Line 182 in 4ea4a55

if (fieldToEdit === CONST.EDIT_REQUEST_FIELD.CATEGORY) {

What alternative solutions did you explore? (Optional)

Remove either Category modal block or CATEGORY constant from request due to unnecessary categories field inside of a one-to-one money request

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Catergory page editable for dms

What is the root cause of that problem?

We have not checked if the category is editable in EditRequestCategoryPage

What changes do you think we should make in order to solve the problem?

We should wrap the EditRequestCategoryPage here with FullPageNotFoundView like we do in other places in the app.

What alternative solutions did you explore? (Optional)

xx