[HOLD for payment 2023-10-24] [$500] iOS - Receipt replace popup camera click button is overlapping with home bar

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Create a request by scanning a receipt.
2. Go to created receipt.
3. Open the receipt details report.
4. Click on receipt image.
5. Click 3 dots menu icon and click replace.

Expected Result:

Camera click button should not overlap with native home bar.

Actual Result:

home button interfering with UI.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.73.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-22.at.3.15.26.PM.1.mov

0-02-01-b4aea41189a95de407693e5e77fe91cc891f9f8064dd68ab2b3005a79f1cd93a_9057d4f9cd9846c.mp4

Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695376096559109

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0191bee1b0a882677e
• Upwork Job ID: 1706314684003328000
• Last Price Increase: 2023-10-09
• Automatic offers:
• ahmedGaber93 | Contributor | 27178584

[ahmedGaber93]

Proposal

Please re-state the problem that we are trying to solve in this issue.

iOS: Receipt replace popup camera click button is overlapping with home bar

What is the root cause of that problem?

We don't include safe area padding bottom to this screen

App/src/pages/EditRequestReceiptPage.js

Lines 31 to 32 in 5aa7f6d

	<ScreenWrapper
	includeSafeAreaPaddingBottom={false}

What changes do you think we should make in order to solve the problem?

We need to include safe area padding bottom by one of:

1. surround DragAndDropProvider content with <View style={[styles.flex1, safeAreaPaddingBottomStyle]}> like money request page do here to ensure DragAndDropProvider work fine in full screen height

<ScreenWrapper
    includeSafeAreaPaddingBottom={false}
>
    {({safeAreaPaddingBottomStyle}) => (
        <>
            <HeaderWithBackButton/>
            <DragAndDropProvider>
                <View style={[styles.flex1, safeAreaPaddingBottomStyle]}>
                    <ReceiptSelector/>
                </View>
            </DragAndDropProvider>
        </>
    )}
</ScreenWrapper>

2. Alternative simply remove prop includeSafeAreaPaddingBottom={false}

What alternative solutions did you explore? (Optional)

remove prop includeSafeAreaPaddingBottom={false}

[esh-g]

Proposal

Please re-state the issue

There is no bottom safe area padding on the EditRequestReceiptPage.

What is the root cause of this issue?

We are setting the includeSafeAreaBottom={false} in the ScreenWrapper in EditRequestReceiptPage.js

App/src/pages/EditRequestReceiptPage.js

Lines 31 to 34 in 4ea4a55

	<ScreenWrapper
	includeSafeAreaPaddingBottom={false}
	shouldEnableMaxHeight
	testID={EditRequestReceiptPage.displayName}

Moreover, there is an inconsistency between the MoneyRequestSelectorPage and EditRequestReceiptPage.js where the DragAndDropProvider covers the entire page including the header in the former, while the header is excluded from the lattter page.

Screen.Recording.2023-09-24.at.11.54.44.AM-1.mov

Here in MoneyRequestSelectorPage we have included the HeaderWithBackButton in the DragAndDropProvider while also using the safeAreaPaddingBottomStyle prop provided by the ScreenWrapper.

App/src/pages/iou/MoneyRequestSelectorPage.js

Lines 86 to 91 in 4ea4a55

	>
	{({safeAreaPaddingBottomStyle}) => (
	<FullPageNotFoundView shouldShow={!IOUUtils.isValidMoneyRequestType(iouType)}>
	<DragAndDropProvider
	isDisabled={props.selectedTab !== CONST.TAB.SCAN}
	setIsDraggingOver={setIsDraggingOver}

What changes do you think should be made to fix this problem?

First we should remove the includeSafeAreaBottom={false} in EditRequsetReceiptPage.js because we want the bottom padding to be present.
Then, we should move the HeaderWithBackButton inside the DragAndDropProvider to provide consistency with the MoneyRequestSelectorPage

App/src/pages/EditRequestReceiptPage.js

Lines 36 to 41 in 4ea4a55

	<HeaderWithBackButton
	title={translate('common.receipt')}
	onBackButtonPress={Navigation.goBack}
	/>
	<DragAndDropProvider>
	<ReceiptSelector

I don't think we need to use the safeAreaPaddingBottomStyle in EditRequestReceiptPage.js because there is no FullPageNotFoundView like in `MoneyRequestSelectorPage.

What other alternative options did you explore? (Optional)

We can also change the MoneyRequestSelectorPage to mirror the behaviour of EditRequestReceiptPage by excluding the header from the DragAndDropProvider but that depends on what we prefer. Since, the EditRequestReceiptPage is newer, I am assuming it was overlooked.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0191bee1b0a882677e

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @anmurali (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)