[HOLD for payment 2023-10-27] [$500] IOU Category - Search message shows 'Invalid email' when typing email address in search field

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #27459

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any workspace chat
3. Go to + > Request money > Manual
4. Enter an amount
5. Click Show more > Category.
6. Enter a few letters, followed by @

Expected Result:

The message below the search field will display 'No results found'..

Actual Result:

The message below the search field displays 'invalid email' when Category search does not involve email

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.73-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6211688_20230923_190412.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0131655c00ab293751
• Upwork Job ID: 1710313308418142208
• Last Price Increase: 2023-10-13
• Automatic offers:
• DylanDylann | Contributor | 27217343

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU Category - Search message shows 'Invalid email' when typing email address in search field

What is the root cause of that problem?

App/src/libs/OptionsListUtils.js

Lines 1476 to 1485 in 5aa7f6d

	if (searchValue && !hasSelectableOptions && !hasUserToInvite) {
	if (/^\d+$/.test(searchValue) && !isValidPhone) {
	return Localize.translate(preferredLocale, 'messages.errorMessageInvalidPhone');
	}
	if (/@/.test(searchValue) && !isValidEmail) {
	return Localize.translate(preferredLocale, 'messages.errorMessageInvalidEmail');
	}
	if (hasMatchedParticipant && (isValidEmail || isValidPhone)) {
	return '';
	}

Let's see the logic to get header message, we are checking if the search value includes "@" we will display errorMessageInvalidEmail instead of noResultsFound

What changes do you think we should make in order to solve the problem?

In this case, we don't search email and phone number

App/src/libs/OptionsListUtils.js

Lines 1477 to 1485 in 5aa7f6d

	if (/^\d+$/.test(searchValue) && !isValidPhone) {
	return Localize.translate(preferredLocale, 'messages.errorMessageInvalidPhone');
	}
	if (/@/.test(searchValue) && !isValidEmail) {
	return Localize.translate(preferredLocale, 'messages.errorMessageInvalidEmail');
	}
	if (hasMatchedParticipant && (isValidEmail || isValidPhone)) {
	return '';
	}

So this logic to redandunt. We need to pass one more params called includeEmailAndPhoneNumber to getHeaderMessage function

and only apply logic to check email and phone if this param is true

What alternative solutions did you explore? (Optional)

[Christinadobrzyn]

Not sure how to make a Category, asking QA - https://expensify.slack.com/archives/C9YU7BX5M/p1695681312874909

[Christinadobrzyn]

still trying to get Categories to work on my c.dobrzyn+45@expensifail.com account.

Asking if anyone else has this issue? https://expensify.slack.com/archives/C01SKUP7QR0/p1695845916425979

[Christinadobrzyn]

I still can't get Category and reached out to the team and they can't get it either so maybe we disabled them. I'm going to close this.

[DylanDylann]

@Christinadobrzyn I still can reproduce this bug on the latest main by enabling permission in the codebase. You can ping C+ team or internal engineer to help verify the bug

[DylanDylann]

@Christinadobrzyn This is an example of category issue: #28079

[DylanDylann]

@s77rt It seems @Christinadobrzyn can't access the category feature. Because you are C+ Contributor of another issue that relates to category #28517. Could you help to verify this is a bug?
Sorry, If I bothers you

[s77rt]

I can reproduce the bug