[HOLD for payment 2023-10-13] [$500] mWeb-Emoticon- In offline, emoji badge not greyed out when applied to the message sent in online

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap profile- preferences
3. Toggle on forced offline
4. Navigate to LHN
5. Tap on a report with emoji badge used in conversation
6. Send a message
7. Long press the message sent and select any suggested emoji to note that added badge is greyed out
8. From above conversation with emoji badge used, tap on emoji picker near by and select it.
9. Note the applied emoji badge is not greyed out
10. From emoji picker, select any emoji for message sent in offline again

Expected Result:

In offline, emoji badge must be greyed out when applied to the message sent in online/offline.

Actual Result:

In offline, emoji badge is not greyed out when applied to the message sent in online.
In offline, emoji badge is greyed out only when applied to the message sent in offline.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.73-0

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6211356_badge.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017fd3015956e36877
• Upwork Job ID: 1706211356001812480
• Last Price Increase: 2023-09-25
• Automatic offers:
• jjcoffee | Reviewer | 26935912
• abdel-h66 | Contributor | 26935913

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[abdel-h66]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Offline mode, emojies that added to an existing message will not have a reduced opacity.

What is the root cause of that problem?

Adding emojies to a comment does not create a pending action related to the action.

App/src/libs/actions/Report.js

Lines 1699 to 1718 in 5aa7f6d

	function addEmojiReaction(reportID, reportActionID, emoji, skinTone = preferredSkinTone) {
	const createdAt = moment().utc().format(CONST.DATE.SQL_DATE_TIME);
	const optimisticData = [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS_REACTIONS}${reportActionID}`,
	value: {
	[emoji.name]: {
	createdAt,
	users: {
	[currentUserAccountID]: {
	skinTones: {
	[!_.isUndefined(skinTone) ? skinTone : -1]: createdAt,
	},
	},
	},
	},
	},
	},
	];

What changes do you think we should make in order to solve the problem?

We can start first by modifying the addEmojiReaction action to correcly have optimistic and failure data as the usual.
I will only provide snippets

[emoji.name]: { pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD, createdAt, users: { [currentUserAccountID]: { skinTones: { [!_.isUndefined(skinTone) ? skinTone : -1]: createdAt, }, }, }, },

for successData and failureData we will just remove the pendingAction from the object.

The second step of the refactoring will be wrapping each emoji inside the OfflineWithFeedback comopnent, and with our new pendingAction property inside the reaction object we willl do something like this.

  <OfflineWithFeedback
      pendingAction={reaction.pendingAction}
      shouldDisableStrikeThrough
  >

recording-issue-28059.mp4

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017fd3015956e36877

[greg-schroeder]

Applying External

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)