[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [$500] Footer for anonymous user sign in modal distorted

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Log out of your test account
2. Go to https://new.expensify.com/r/7277649907280010
3. See the "Welcome to #public-rooooom!"
4. Click on the Sign In button
5. Scroll down to the bottom of the page and observe the footer

Expected Result:

It should not get distorted and show the list in vertical order

Actual Result:

It gets distorted

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.73-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

bandicam.2023-09-22.17-37-58-153.mp4

Screen.Recording.2023-09-18.at.17.06.57.1.mov

Expensify/Expensify Issue URL:
Issue reported by: @Pujan92
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695037709793059

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0173528f51d8bbad2d
• Upwork Job ID: 1705243190334554112
• Last Price Increase: 2023-09-22
• Automatic offers:
• Pujan92 | Contributor | 27016148
• Pujan92 | Reporter | 27016149

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0173528f51d8bbad2d

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[kavimuru]

Proposal by @Pujan92

Please re-state the problem that we are trying to solve in this issue.

Footer for the sign in modal is distorted

What is the root cause of that problem?

For the sign in page content inside the modal we are not passing the prop for the Footer to inform about getting it open in the modal/smaller width.

App/src/pages/signin/SignInPageLayout/index.js

Line 172 in 0233376

<Footer scrollPageToTop={scrollPageToTop} />

What changes do you think we should make in order to solve the problem?

We need to pass prop isSmallScreenWidth explicitly as we know it is going to open in the small screen or right-side modal.

App/src/pages/signin/SignInPageLayout/index.js

Line 172 in 0233376

<Footer scrollPageToTop={scrollPageToTop} />

What alternative solutions did you explore? (Optional)

Pass prop isInModal to the Footer component and use that value to decide whether to show vertically or not. The way we are doing in the SignInPageLayout component here.

App/src/pages/signin/SignInPageLayout/index.js

Line 65 in a211b6d

const shouldShowSmallScreen = props.isSmallScreenWidth || props.isInModal;

App/src/pages/signin/SignInPageLayout/Footer.js

Line 153 in a211b6d

const isVertical = props.isSmallScreenWidth;

const isVertical = props.isSmallScreenWidth || props.isInModal;