[HOLD for payment 2023-10-16] [HOLD for payment 2023-10-13] [$500] LOW: Web - Clicking on "Replace" for a paid scan request results in the scan modal opening and then closing automatically

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Log in with User A.
2. Open a chat with User B.
3. Go to the "Request money" section and select "Scan."
4. Send a scanned image.
5. Click on the sent image and go to its details.
6. Go to User B's account.
7. Click on "Pay elsewhere."
8. Return to User A's account.
9. Click on the scanned image and attempt to replace it

Expected Result:

When clicking on "Replace" for a paid scan request, the scan modal should either remain open or not open at all, depending on the intended functionality

Actual Result:

Clicking on "Replace" for a paid scan request causes the scan modal to open briefly and then close automatically

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.72.8
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-recording-2023-09-20-at-22122-pm_sWMvL9a8.mp4

Recording.4676.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695202167946769

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0106bd3efbb87edef7
• Upwork Job ID: 1704962599505321984
• Last Price Increase: 2023-09-21
• Automatic offers:
• dukenv0307 | Contributor | 26918886

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0106bd3efbb87edef7

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @NicMendonca (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (External)

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Clicking on "Replace" for a paid scan request results in the scan modal opening and then closing automatically

What is the root cause of that problem?

This happens because in AttachmentModal.js we allow the user to navigate to the edit request route without checks.

The menuItem does not have any checks:

App/src/components/AttachmentModal.js

Lines 361 to 369 in 65fd435

	threeDotsMenuItems={[
	{
	icon: Expensicons.Camera,
	text: props.translate('common.replace'),
	onSelected: () => {
	onModalHideCallbackRef.current = () => Navigation.navigate(ROUTES.getEditRequestRoute(props.report.reportID, CONST.EDIT_REQUEST_FIELD.RECEIPT));
	closeModal();
	},
	},

This results in navigating to EditRequestPage.js

here if canEdit for this request is false, this useEffect dismisses the modal:

App/src/pages/EditRequestPage.js

Lines 96 to 103 in e24e431

	useEffect(() => {
	if (canEdit) {
	return;
	}
	Navigation.isNavigationReady().then(() => {
	Navigation.dismissModal();
	});
	}, [canEdit]);

This causes the flash.

What changes do you think we should make in order to solve the problem?

• Solution 1:

  We can show a message that says that we are not allowed to edit this when editRequest page is accessed without the permission to edit.
  Since EditPage is a core page, it can be accessed via many places.
  The opening and quickly dismissing the modal is programmed into the page itself, that we should fix. Instead of dismissing the Page, we can inform the user that this action is not allowed.
  We can accomplish this by:

  • Showing a Modal:

    This is how it would look like:

Screencast.from.22-09-23.07.38.47.AM.IST.webm

• Showing a Page

  • Another way would be to create a FullPageActionNotAllowed component that will inform the user that "this action is not allowed":

Screencast.from.22-09-23.07.50.41.AM.IST.webm

This would also be better UX as when accessed from other paths, instead of just dismissing a clear message is shown.

• Solution 2:

  We will also remove the menuItem if the report is Settled.

  This can be done by adding a check for settled Iou to the menuItem here:
  

  App/src/components/AttachmentModal.js

  Lines 361 to 369 in 65fd435

  	threeDotsMenuItems={[
  	{
  	icon: Expensicons.Camera,
  	text: props.translate('common.replace'),
  	onSelected: () => {
  	onModalHideCallbackRef.current = () => Navigation.navigate(ROUTES.getEditRequestRoute(props.report.reportID, CONST.EDIT_REQUEST_FIELD.RECEIPT));
  	closeModal();
  	},
  	},

   const parentReport = ReportUtils.getParentReport(props.report);
   const parentReportAction = ReportActionsUtils.getParentReportAction(report);
   const isSettled = ReportUtils.isSettled(parentReport.reportID);
   const isDeleted = ReportUtils.isDeleted(parentReportAction.reportID);
   const isRequestor = ReportUtils.isMoneyRequestReport(parentReport) && lodashGet(session, 'accountID', null) === parentReportAction.actorAccountID;
   // now we have all the info:
   const canReplace = !isSettled && !isDeleted && isRequestor;

  We can then use canReplace to conditionally Render the menuItem here
  Note: We will restructure code to not make these library calls if the Attachment Modal is not a receipt

What alternative solutions did you explore? (Optional)

xx

[huzaima]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When clicking on "Replace" for a paid request, the modal should not show the "Replace" option.

What is the root cause of that problem?

The settled report cannot be edited. It's checked here:

App/src/pages/EditRequestPage.js

Lines 96 to 103 in e24e431

	useEffect(() => {
	if (canEdit) {
	return;
	}
	Navigation.isNavigationReady().then(() => {
	Navigation.dismissModal();
	});
	}, [canEdit]);

Now in AttachmentModal.js, we don't check if the request was settled and unconditionally redirect to EditRequestPage.

What changes do you think we should make in order to solve the problem?

We should check if the request was settled and shouldn't show the "Replace" menu item if it's settled. In AttachmentModal.js, we should check if the parentReport is settled. It's important to check parentReport. If we do ReportUtils.isSettled(props.report.reportID), it will be incorrect. We should first get the parent report like this:

const parentReport = ReportUtils.getParentReport(props.report);

and then check ReportUtils.isSettled(parentReport.reportID).