[HOLD for payment 2023-10-13] [$500] Chat - Creating a new line in composer causes the composer to jump when expanding

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any chat
3. Click on the composer
4. Create a new line by Shift + Enter

Expected Result:

The composer does not jump when expanding

Actual Result:

The composer jumps when expanding

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• MacOS / Desktop
• MacOS / Chrome / Safari
• Windows / Chrome

Version Number: 1.3.72-6

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6207916_20230921_020518.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0199195af3f24f9d73
• Upwork Job ID: 1705074693317824512
• Last Price Increase: 2023-09-22
• Automatic offers:
• s-alves10 | Contributor | 26864648

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[tylerkaraszewski]

I've confirmed this happens but I'm not sure where to look to fix it.

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Creating a new line in the main composer causes the composer to jump while expading

What is the root cause of that problem?

We determine the vertical padding here based on numberOfLinesProp

App/src/components/Composer/index.js

Line 447 in 5ff88b7

StyleUtils.getComposeTextAreaPadding(numberOfLinesProp, isComposerFullSize),

And we pass numberOfLines props to RNTextInput component here

App/src/components/Composer/index.js

Line 468 in 5ff88b7

numberOfLines={numberOfLines}

The problem is in the mismatch of numberOfLines and numberOfLinesProp
When needed, we change both the numberOfLines state and numberOfLinesProp here

App/src/components/Composer/index.js

Lines 364 to 366 in 5ff88b7

	onNumberOfLinesChange(generalNumberOfLines);
	updateIsFullComposerAvailable({isFullComposerAvailable, setIsFullComposerAvailable}, generalNumberOfLines);
	setNumberOfLines(generalNumberOfLines);

but changing numberOfLinesProp requires Onyx merge and takes some more time

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions.js

Line 232 in 5ff88b7

Report.saveReportCommentNumberOfLines(reportID, newNumberOfLines);

So numberOfLinesProps changes a little bit later than numberOfLines state
This makes the composer jump

What changes do you think we should make in order to solve the problem?

We don't need to calculate the vertical padding based on numberOfLinesProps props. We have numberOfLines state and get padding based on this. This makes more sense than using props because this value represent the current state of the composer.

    const inputStyleMemo = useMemo(
        () => [
            // We are hiding the scrollbar to prevent it from reducing the text input width,
            // so we can get the correct scroll height while calculating the number of lines.
            numberOfLines < maxLines ? styles.overflowHidden : {},

            StyleSheet.flatten([style, {outline: 'none'}]),
            StyleUtils.getComposeTextAreaPadding(numberOfLines, isComposerFullSize),
        ],
        [style, maxLines, numberOfLines, isComposerFullSize],
    );

This works as expected

Result

27892.mp4

What alternative solutions did you explore? (Optional)