[HOLD for payment 2023-12-29] [Paid] [$500] Web - I accept checkbox is not aligned with errors

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open settings->workspaces->any workspaces-> bank account -> connect manually
3. Click on Continue
4. Observe that I accept checkbox is not aligned with errors and red dot on the page

Expected Result:

I accept checkbox should be aligned with errors red dot

Actual Result:

I accept checkbox is not aligned with errors red dot

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.71.4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694958144361539

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015553e32dfe1adcdf
• Upwork Job ID: 1703830965747298304
• Last Price Increase: 2023-09-25
• Automatic offers:
• mollfpr | Reviewer | 27001512
• BhuvaneshPatil | Contributor | 27001514

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015553e32dfe1adcdf

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue

The red dot and the checkout are not centered

What is the root cause of that problem?

Since the red dot is smaller in size than checkbox, so checkbox is not aligned with errors red dot

What changes do you think we should make in order to solve the problem?

We can create wrapper for red dot which will correspond to the checkout sizes and place the dot in the middle with styles
[{height: 24, width: 24}, styles.alignItemsCenter, styles.justifyContentCenter]

For this dot

App/src/components/FormHelpMessage.js

Lines 42 to 47 in 6836eaf

	{props.isError && (
	<Icon
	src={Expensicons.DotIndicator}
	fill={themeColors.danger}
	/>
	)}

And if we want to make text as the same level we can also change styles here like

wrapperStyle={[styles.ml2, styles.pr2, styles.w100, styles.flexWrap, styles.flexShrink1]}

App/src/components/CheckboxWithLabel.js

Line 117 in 6be8fca

wrapperStyle={[styles.ml3, styles.pr2, styles.w100, styles.flexWrap, styles.flexShrink1]}

What alternative solutions did you explore? (Optional)

NA