[HOLD for payment 2023-11-07] [$500] iOS: "Connect online with Plaid" popup is opened repeatedly after resuming the app.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to account settings >> Workspace.
2. Click on the workspace to view its settings.
3. Click on Cards or Reimbursements settings.
4. Select "Connect bank account" >> "Connect online with Plaid."
5. Swipe down from the top of the device's screen to view notifications.
6. Swipe up to hide notifications.
7. Observe that the "Connect online with Plaid" popup opens again.

Expected Result:

"Connect online with Plaid" popup is opened only once

Actual Result:

Connect online with Plaid popup is opened repeatedly
NOTE : Can be reproduced with the steps 5. Put app to background and Resume app from background

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.70-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

popup-opened-repeatedly-02.MP4

popup-opened-repeatedly-01.MP4

WPNF8768.1.MP4

Expensify/Expensify Issue URL:
Issue reported by: @tranvantoan-qn
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694619647610939

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b7bfe22feb2b9545
• Upwork Job ID: 1703386549654556672
• Last Price Increase: 2023-09-17
• Automatic offers:
• situchan | Contributor | 26773159
• tranvantoan-qn | Reporter | 26773161
• pradeepmdk | Contributor | 27260708

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b7bfe22feb2b9545

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @adelekennedy (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[kushu7]

Proposal

Please re-state the problem that we are trying to solve in this issue.

iOS: "Connect online with Plaid" popup is opened repeatedly after resuming the app

What is the root cause of that problem?

Problem is PlaidLink is not getting closed on component unmount.
we are not handling any unmount case here.

App/src/components/PlaidLink/index.native.js

Lines 20 to 28 in c77814f

	onExit: (exitError, metadata) => {
	Log.info('[PlaidLink] Exit: ', false, {exitError, metadata});
	props.onExit();
	},
	});
	// We generally do not need to include the token as a dependency here as it is only provided once via props and should not change
	// eslint-disable-next-line react-hooks/exhaustive-deps
	}, []);

and ReimbursementAccountPage get remounted on focus due to this this.props.isLoadingReportData

App/src/pages/ReimbursementAccount/ReimbursementAccountPage.js

Line 352 in c77814f

const isLoading = this.props.isLoadingReportData || this.props.account.isLoading || this.props.reimbursementAccount.isLoading;

resulting unmounting of PlaidLink due to ReimbursementAccountLoadingIndicator.

What changes do you think we should make in order to solve the problem?

We can update PlaidLink to close Plaid Popover on component unmount.
we can add this code on useEffect cleanup to dismiss PlaidLink on unmount by using dismissLink method of react-native-plaid-link-sdk

const ref = useRef({ isVisible: false })
.....
.....
    useEffect(() => {
        ref.current.isVisible = true
        openLink({
        .....
            onSuccess: ({ publicToken, metadata }) => {
                ref.current.isVisible = false;
                props.onSuccess({ publicToken, metadata });
            },
            onExit: (exitError, metadata) => {
                Log.info('[PlaidLink] Exit: ', false, { exitError, metadata });
                ref.current.isVisible = false;
                props.onExit();
            },
        });

        return () => {
            // eslint-disable-next-line react-hooks/exhaustive-deps
            if (!ref.current.isVisible) return;
            dismissLink();
        }
    }, []);

Result

Simulator.Screen.Recording.-.iPhone.14.Pro.Max.-.2023-09-17.at.19.34.41.mov

What alternative solutions did you explore? (Optional)

None

[pradeepmdk]

Proposal

Please re-state the problem that we are trying to solve in this issue.

iOS: "Connect online with Plaid" popup is opened repeatedly after resuming the app

What is the root cause of that problem?

when notification open apps going to background mode. so when the notification closed app again active and reconnect api triggering

App/src/pages/ReimbursementAccount/ReimbursementAccountPage.js

Line 352 in c77814f

const isLoading = this.props.isLoadingReportData || this.props.account.isLoading || this.props.reimbursementAccount.isLoading;

when reconnect api calling isLoadingReportData false and true

App/src/pages/ReimbursementAccount/ReimbursementAccountPage.js

Line 416 in c77814f

<BankAccountStep

component is unmount and mount. so that popup is opening again

What changes do you think we should make in order to solve the problem?

create new onyx key PLAID_CURRENT_EVENT; and store the event in the onyx
function setPlaidEvent(eventName) { return Onyx.set(ONYXKEYS.PLAID_CURRENT_EVENT, eventName); }
save this event from here

App/src/components/AddPlaidBankAccount.js

Line 224 in c77814f

// Handle Plaid login errors (will potentially reset plaid token and item depending on the error)

and
subscribe to this event and check the open condition

App/src/pages/ReimbursementAccount/ReimbursementAccountPage.js

Line 363 in c77814f

if ((!this.state.hasACHDataBeenLoaded || isLoading) && shouldShowOfflineLoader && (shouldReopenOnfido || !this.requestorStepRef.current)) {

if ((!this.state.hasACHDataBeenLoaded || (isLoading && this.props.PLAID_CURRENT_EVENT != 'OPEN')) && shouldShowOfflineLoader && (shouldReopenOnfido || !this.requestorStepRef.current)) {
and plaid popup loading mode there is no event so handle that

App/src/components/PlaidLink/index.native.js

Line 12 in c77814f

useEffect(() => {

here we need add props.onEvent('OPEN', {});
and here no unmount handle we can dismiss the link on unmount

App/src/components/PlaidLink/index.native.js

Line 26 in c77814f

// We generally do not need to include the token as a dependency here as it is only provided once via props and should not change

return () => { dismissLink(); }

and finally, we should clear here

function clearPlaid() {
    Onyx.set(ONYXKEYS.PLAID_LINK_TOKEN, '');
    Onyx.set(ONYXKEYS.PLAID_CURRENT_EVENT, '');
    return Onyx.set(ONYXKEYS.PLAID_DATA, PlaidDataProps.plaidDataDefaultProps);
}

Result

Untitled.mp4