Remove `setTimeout` usage in AttachmentPicker/index.native.js

[kidroca]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Expected Result:

The Attachment Picker modal should work correctly without the need of setTimeout

Actual Result:

setTimeout is needed because on iOS the Gallery/Camera is immediately dismissed when the Attachment bottom docked modal closes

Details

This is a follow up on #2656 (comment)
It can potentially be resolved by updating the attachment related libraries handled in this ticket: #2531

Action Performed:

1. Open a chat
2. Select (+) button to add an attachment
3. Select gallery
4. Sometimes the gallery would open and immediately close or not open at all

Workaround:

Added a brief timeout so that the Camera/Gallery is only opened a 1-2 frames after the Attachment Picker modal closes

Platform:

Where is this issue occurring?

• Web
• ✅ iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.0.38-1
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on Upwork

[mallenexpensify]

@kidroca sorry for the delay here. (we've recently improved our process so new issues will get reviewed very quickly now)
I tried to reproduce on three chats in iOS (and iOS mWeb Safari) and wasn't able to. Can you see if you can reproduce and, if so, provide more details include a screen video recording?
Thanks,
Matt

[kidroca]

@mallenexpensify
There's no bug to reproduce here
This is a refactor remainder ticket so that we can update the code that uses setTimeout and remove the setTimeout usage
It can be done right now as this will introduce a bug

[mallenexpensify]

Thanks for the context @kidroca. I'm not an engineer so will loop one in here to review.

[MelvinBot]

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[bondydaa]

Cool yep I agree we should not rely on a setTimeout as mentioned in the PR.

I think this could probably be worthwhile for an external contributor, I'm guessing @kidroca might have an idea of how to do this even?

I'm not sure it needs to be a daily, weekly is probably good for now since the sooner we get it cleaned up the less likely we will need to put more setTimeouts in the code to push things further back in the call stack.

[bondydaa]

I don't exactly have the time right now to manage external contributors so I'm not going to apply the external label but @mallenexpensify if you want to so we can get the job up on upwork go for it, i'll ask in engineering-chat as well.