[HOLD for payment 2023-09-29] [$500] Web - App does not display address suggestion after clicking 'Fix the errors' link

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Click on plus and click on request money
3. Click on distance
4. Open Start/Finish
5. Type in any random text and click on Save
6. Focus back on input, remove the random text and type in text which will trigger suggestions eg: ind
7. When suggestion is open, click on 'Fix the errors' link
8. Observe that suggestion closes, try removing all text and rewrite text that will trigger suggestions and observe that suggestions are not displayed
9. Click in empty space below input to lose focus and again focus on input, observe that now suggestions work fine

Expected Result:

Fix the errors link should not disable address suggestions

Actual Result:

Fix the errors link disables address suggestions in waypoint pages

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.67.2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

suggestion.address.is.not.triggered.again.mov

Recording.4394.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694107628159709

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017e44e8bf9e07ab26
• Upwork Job ID: 1701286801034104832
• Last Price Increase: 2023-09-18
• Automatic offers:
• jjcoffee | Reviewer | 26745226
• bernhardoj | Contributor | 26745229
• dhanashree-sawant | Reporter | 26745230

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017e44e8bf9e07ab26

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @strepanier03 (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[abdel-h66]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Suggestions list disappears after clicking 'Fix the errors' link

What is the root cause of that problem?

When clicking fix the errors link, the Text input does not seem to be blurred, as the onBlur is never trigerred. Not sure if this is coming from the Autocomplete lib or something else.

What changes do you think we should make in order to solve the problem?

I have found a way to force the blur on the text input when calling onFixTheErrorsLinkPressed

App/src/components/Form.js

Lines 421 to 423 in fd3a753

	if (focusInput.focus && typeof focusInput.focus === 'function') {
	focusInput.focus();
	}

By checking if the input is focused, forcing it to go onBlur and then call the focus() method

                            // Focus the input after scrolling, as on the Web it gives a slightly better visual result
                            if (focusInput.focus && typeof focusInput.focus === 'function') {
                                if(focusInput.isFocused()) {
                                    focusInput.blur();
                                }
                                focusInput.focus();
                            }

What alternative solutions did you explore? (Optional)

N/A

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Address autocomplete suggestion list hides when we press Fix the errors.

What is the root cause of that problem?

This issue is coming from our fork of react-native-google-places-autocomplete. Clicking the Fix the errors shouldn't close the list because the input is still in a focused state, but this (old) PR adds a new behavior to the lib to always hide the list if we click outside of the autocomplete suggestion element.

It's to fix this issue where the list didn't close if we moved away from it using the Tab key. The root cause of it is explained here. The solution to that issue is:

1. Hide the list of a click that happened outside of the autocomplete elements.
2. Add onBlur to each list item Pressable so moving away with Tab will call the onBlur

onBlur will hide the list if the blur is triggered by elements outside of the autocomplete elements.

What changes do you think we should make in order to solve the problem?

The hide when clicking outside solution (1) is actually not necessary. It's to handle the case where the list is still visible after moving away from it using the Tab key, but it won't ever happen if we already hide it when we are moving away from the list by putting onBlur to each item in the list (2).

So, the solution is simply to remove the hide when clicking outside logic (outsideClickHandler).