[HOLD for payment 2023-10-12] [$500] [Distance] Web - Map and map image doesn't zoom out and display long unconventional routes

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

. Open the app
2. Click on plus and click on request money
3. Click on 'Distance'
4. In start, select 'India' and in Finish, select 'Pakistan'
5. Observe that map does not display the whole route as it is not straightforward
6. Complete the process, open the request money message twice to open request money page
7. Click on map image to see that map does not display the route fully

Expected Result:

App should zoom out to display full route in map and image

Actual Result:

App does not zoom out to display full route in map and image for long distance unconventional routes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.67.2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

doesnt.zoom.out.to.display.full.route.mp4

Recording.4391.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694103719072409

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c90939608885c398
• Upwork Job ID: 1701278392102277120
• Last Price Increase: 2023-09-11
• Automatic offers:
• mollfpr | Reviewer | 26914479
• dhanashree-sawant | Reporter | 26914481

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c90939608885c398

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @kevinksullivan (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[sumairq]

Proposed solution

Please re-state the problem that we are trying to solve in this issue.

Assign Task - Web - Map and map image doesn't zoom out and display long unconventional routes

What is the root cause of that problem?**

getBounds function in the utils for mapbox does not add buffer zone around the calculated bounds and does not calculate a zoom level that comfortably fits the entire route within the map's view.

What changes do you think we should make in order to solve the problem?**

• Add a buffer zone around the calculated bounds. This will ensure that the route is not displayed right at the map's edge, leaving some margin for better visibility.
• Calculate the zoom level based on the distance between the north-east and south-west coordinates. This will all us to set a zoom level that comfortably fits the entire route within the map's view.
• Calculate the center of the bounding box, which will be used as the map's new center after zooming.
  

  App/src/components/MapView/utils.ts

  Lines 1 to 13 in f4affe5

  	function getBounds(waypoints: Array<[number, number]>): {southWest: [number, number]; northEast: [number, number]} {
  	const lngs = waypoints.map((waypoint) => waypoint[0]);
  	const lats = waypoints.map((waypoint) => waypoint[1]);
  	return {
  	southWest: [Math.min(...lngs), Math.min(...lats)],
  	northEast: [Math.max(...lngs), Math.max(...lats)],
  	};
  	}
  	export default {
  	getBounds,
  	};

Following calculations can be added in the getBounds() utility function.

  const center = [
        (northEast[0] + southWest[0]) / 2,
        (northEast[1] + southWest[1]) / 2,
    ];

    // Calculates the distance between the north-east and south-west coordinates
    const distanceLng = northEast[0] - southWest[0];
    const distanceLat = northEast[1] - southWest[1];

    // Calculates the zoom level based on the bounding box dimensions and buffer
    const zoomLng = Math.log2((360 / distanceLng) * (1 + bufferFactor));
    const zoomLat = Math.log2((180 / distanceLat) * (1 + bufferFactor));
    const zoom = Math.min(zoomLng, zoomLat);

What alternative solutions did you explore? (Optional)

none