[HOLD for payment 2023-10-09] [$500] Web - App displays waypoint address page briefly on click on 'Go back to Home page'

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open request money
3. Click on distance
4. Click on Start/Finish
5. Copy the URL
6. Modify number in the end of URL and send it to any chat (this is to trigger 'Hmm its not here' page)
7. Click on link, it should display 'Hmm its not here' page
8. Click on 'Go back to Home page' and observe that it displays waypoint address page in transition

Expected Result:

App should not display any other page on click on 'Go back to Home page'

Actual Result:

Waypoint page is briefly displayed when clicking on 'Go back to Home page'

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.66.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

go.back.to.home.page.transition.page.mp4

Recording.4362.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693910663601209

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01820733228279d2b2
• Upwork Job ID: 1700868221786181632
• Last Price Increase: 2023-09-10
• Automatic offers:
• ZhenjaHorbach | Contributor | 26787091
• dhanashree-sawant | Reporter | 26787093

[ahmedGaber93]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App displays waypoint page in 'Go back to home page' transition

What is the root cause of that problem?

App/src/pages/iou/WaypointEditor.js

Line 166 in 5c13816

<FullPageNotFoundView shouldShow={(Number.isNaN(parsedWaypointIndex) || parsedWaypointIndex < 0 || parsedWaypointIndex > waypointCount - 1) && isFocused}>

When clicking going back, the isFocused in shouldShow condition will be false, then shouldShow will be false and the content inside it will appear.

The isFocused is added here to fix an issue appeared unexpectedly and not related to the PR here #25977 (comment)

"when deleting a waypoint, the Not Found screen became visible for a few milliseconds during the animation"

And it fixed by isFocused, and it fixed correctly, but the fix not cover this case.

What changes do you think we should make in order to solve the problem?

We need to remove isFocused from shouldShow condition and it will work fine.

We will replace isFocused with a new fix for:

"when deleting a waypoint, the Not Found screen became visible for a few milliseconds during the animation"

When start deleting, we will save state and use it in shouldShow to prevent showing Not found page.

// define state
const [didDelete, setDidDelete] = useState(false);

// set it here
const deleteStopAndHideModal = () => {
    setDidDelete(true);
    ...
};
//and here
const onSubmit = (values) => {
  ...
  // Allows letting you set a waypoint to an empty value
  if (waypointValue === '') {
      setDidDelete(true);
      ...
  }
}

// use it here
<FullPageNotFoundView 
  shouldShow={(Number.isNaN(parsedWaypointIndex) || parsedWaypointIndex < 0 || parsedWaypointIndex > waypointCount - 1) && !didDelete}>

Now if this part parsedWaypointIndex > waypointCount - 1 return true, the new part && !didDelete will prevent it

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01820733228279d2b2

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @NicMendonca (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[kbecciv]

Proposal by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693910663601209

Proposal

Please re-state the problem that we are trying to solve in this issue.

We are solving the problem of app displaying waypoint page in transition of go back to home page

What is the root cause of that problem?

Currently we have isFocused check in shouldShow check of FullPageNotFoundView of WaypointEditor page. When we click on 'Go back to home page' on waypoint page, it removes focus from address field making isFocused false

What changes do you think we should make in order to solve the problem?

We cannot keep the focus on address field on 'Go back to home page' click as we are using native component for that part. Ideally, we can remove isFocused condition to solve the issue.
We can do that by changing the code here

<FullPageNotFoundView shouldShow={(Number.isNaN(parsedWaypointIndex) || parsedWaypointIndex < 0 || parsedWaypointIndex > waypointCount - 1)}>

What alternative solutions did you explore? (Optional)