[$500] Re-entering same wrong magic code and verify keeps last digit in green

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open settings ->profile-> contact method->add any contact method
3. Open that newly added contact method and enter wrong code
4. Dismiss the error and again add same wrong code over it
5. Click verify and observe that last digit still has green dash

Expected Result:

App should have red dash below all the digits when error is triggered in add contact method

Actual Result:

App displays last digit with green dash when error is dismissed and again same code is entered and error is triggered in add contact method

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.63-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

green.dash.on.last.digit.on.re.enter.same.code.mp4

Recording.421.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693501161646589

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013d5900e7078ce653
• Upwork Job ID: 1699715481614094336
• Last Price Increase: 2023-09-28

[melvin-bot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[m-natarajan]

Proposal by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693501161646589

Proposal

Please re-state the problem that we are trying to solve in this issue.

We are solving the problem of app displaying green border to magic code first and last field when submitted without any value or when resubmitted same value

What is the root cause of that problem?

Currently in MagicCodeInput component, there is not way to find out whether verify button was triggered or not due to which focusedIndex value is not changed whenever we trigger verify. This lack of data is causing green background for first or last digit even on error in multiple different scenario's like:

1. verify button click when there is no input
2. verify button click when we re-enter same invalid code

What changes do you think we should make in order to solve the problem?

We have to introduce variable which will let us know that verify button was triggered and introduce new condition to display borderColorFocus. This will help us to not only solve the issue for current scenarios but also fullproof the solution for any other such scenarios.
In BaseValidateCodeForm page of settings->profile->Contacts:
We can add verifyCode state at following location

const [verifyClick,setVerifyClick]= useState(false);

Set the state to true on verify button click at following location

setVerifyClick(true);

Pass on both the variable and method (so we can again it to false on focus of any input) at following location

verifyClick={verifyClick}
verifyClickChange={setVerifyClick}

In MagicCodeInput component:
Set default prop values to avoid issues with component used at different location (tested at all other locations to see if its working fine or not) by adding the code [here] (

App/src/components/MagicCodeInput.js

Line 62 in 9701fbe

hasError: false,

):

verifyClick: false,
verifyClickChange: ()=>{},

Modify style condition for the digit view to allow borderColorFocus only if value is false by changing code here

focusedIndex === index && !props.verifyClick ? styles.borderColorFocus : {},

Set verifyClick value to false in onFocus to ensure it only affects once after verify button click and does not hinder normal border color change by adding code here

props.verifyClickChange(false)

This will also modify state value in BaseValidateCodeForm of settings->profile->Contacts.

What alternative solutions did you explore? (Optional)

[alitoshmatov]

Dupe - #20416

[conorpendergrast]

@alitoshmatov Can you add some context? Same root cause, but different effect?

[bernhardoj]

I think it's not a dupe. In this issue, the validation request does not run at all when the magic code value is the same.

[alitoshmatov]

@bernhardoj You right, I think I made mistake. It does not look same
cc: @conorpendergrast

[conorpendergrast]

Nice, thanks for the confirmation there! I'll review and triage this accordingly

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013d5900e7078ce653