[HOLD for payment 2023-09-12] [HOLD for payment 2023-09-11] [$1000] IOU - Currency edit in confirmation page causes missing header and wrong redirection

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #26520

Action Performed:

1. Go to staging.new.expensify.com
2. Go to + > Request money > Enter an amount > Select a payer
3. On confirmation page, click on the Amount
4. Edit the amount only > Click Next
5. On the confirmation page, click on the Amount again
6. Change the currency
7. Click Next

Expected Result:

In Step 6, Amount header does not disappear
In Step 7, user is redirected to the confirmation page

Actual Result:

In Step 6, Amount header disappears
In Step 7, user is redirected to the payer selection page. This is a different behavior observed in Step 4 when user is redirected to the confirmation page when the amount is changed

Action Performed:

1. Go to staging.new.expensify.com
2. Go to + > Request money
3. Enter an amount
4. Change the currency

Expected Result:

The amount is preserved and does not change

Actual Result:

The amount is not preserved and it changes to zero

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.62-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6186258_20230902_233538.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010711a82a596d6dcc
• Upwork Job ID: 1698168980758937600
• Last Price Increase: 2023-09-03

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[napster125]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Currency edit in confirmation page causes missing header and wrong redirection

What is the root cause of that problem?

470c54a caused regression.

App/src/pages/iou/IOUCurrencySelection.js

Line 87 in e088539

Navigation.goBack(`${props.route.params.backTo}?currency=${option.currencyCode}`, true);

In this code snippet, the goBack function with true as the second parameter replaces the modal without considering the previous state. This leads to unexpected behavior, such as the issue we've encountered and the resetting of text input.

What changes do you think we should make in order to solve the problem?

We should use Navigation.navigate function instead of goBack function.

Navigation.navigate(`${props.route.params.backTo}?currency=${option.currencyCode}`);

What alternative solutions did you explore? (Optional)

N/A

[shubham1206agra]

@marcaaron If you have no problem, we should combine this with #26587

[hayata-suenaga]

This was probably caused by #25707

We need to solve this my Monday and it's weekend. I gonna make this external to get immediate proposals and PRs.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010711a82a596d6dcc