[HOLD for payment 2023-10-09] [HOLD for payment 2023-09-29] [$500] There is a larger gap between the Apple icon and the Google icon on Android

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to login page

Expected Result:

The gap should be consistent across all platforms

Actual Result:

The gap is larger on Android

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.62-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @aman-atg
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693020637974179

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0158363a81364181da
• Upwork Job ID: 1698574418489659392
• Last Price Increase: 2023-09-04
• Automatic offers:
• aman-atg | Contributor | 26711713
• aman-atg | Reporter | 26711715

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kavimuru]

Proposal from @aman-atg

Please re-state the problem that we are trying to solve in this issue.

There is a larger gap between the Apple icon and the Google icon on Android

What is the root cause of that problem?

The root cause of the problem is the styles provided to IconButton here as it provides margin:10px for both buttons resulting in a larger gap in native devices since IconButton is being used there.

What changes do you think we should make in order to solve the problem?

We should make changes here to avoid horizontal margin for both buttons. Then, we can use gap: 12 for button containers or marginLeft: 12 for Google Button on all platforms to have consistent spacing.

What alternative solutions did you explore? (Optional)

[sophiepintoraetz]

@kavimuru - please make sure you're checking all the affected platforms.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0158363a81364181da

[melvin-bot]

Current assignee @sophiepintoraetz is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is a smaller gap between the Apple icon and the Google icon on Web/mWeb

What is the root cause of that problem?

In Desktop/Native apps, we use the IconButton component to render Apple and Google icon

App/src/components/SignInButtons/GoogleSignIn/index.desktop.js

Lines 21 to 26 in d58bc2a

	<IconButton
	onPress={() => {
	window.open(googleSignInWebRouteForDesktopFlow);
	}}
	provider={CONST.SIGN_IN_METHOD.GOOGLE}
	/>

But in Web, we use a primitive div to render them

App/src/components/SignInButtons/AppleSignIn/index.website.js

Lines 84 to 94 in d58bc2a

	<div
	id="appleid-signin"
	data-mode="center-align"
	data-type="continue"
	data-color="white"
	data-border="false"
	data-border-radius="50"
	data-width={CONST.SIGN_IN_FORM_WIDTH}
	data-height="52"
	style={{cursor: 'pointer'}}
	/>

So I think the inconsistency here is in Web/mWeb, it's not in neither Desktop or native apps. In Web/mWeb platform, we forgot to apply the same margin for icons here

App/src/components/SignInButtons/IconButton.js

Line 39 in d58bc2a

style={styles.signInIconButton}

What changes do you think we should make in order to solve the problem?

In AppleSignIn and GoogleSignIn components for web, we need to apply the same style as we applied for native platforms, which is styles.signInIconButton. So the gap between icons will be consistency among platforms.

App/src/components/SignInButtons/AppleSignIn/index.website.js

Line 104 in d58bc2a

style={{cursor: 'pointer'}}