[$500] Web - Incorrect border color for thumbnail image on hovering the money request with receipt

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Create a money request with the scan option
2. Wait for the receipt to be scanned successfully
3. Hover on the money request in the IOU report
4. Observe the border color seems off and not match with the box highlight color

Expected Result:

Thumbnail image border color should be match with the box highlight color on money request preview hover

Actual Result:

Thumbnail image border color isn't same with box highlight color on money request preview hover

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.60.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-24.at.19.48.32.mov

Recording.4112.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Pujan92
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692886933783429

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a01f6f0ca75cd457
• Upwork Job ID: 1699516966679310336
• Last Price Increase: 2023-09-27
• Automatic offers:
• aimane-chnaif | Reviewer | 27128688
• Pujan92 | Contributor | 27128690
• Pujan92 | Reporter | 27128691

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kbecciv]

Proposal by: @Pujan92
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692886933783429

Proposal

Please re-state the problem that we are trying to solve in this issue.

Incorrect border color for thumbnail image on hovering the money request with receipt

What is the root cause of that problem?

We are setting the correct border color only for isScanning part but not for the hovered part here.

App/src/components/ReportActionItem/MoneyRequestPreview.js

Line 226 in 329cac3

isHovered={isScanning}

What changes do you think we should make in order to solve the problem?

We need to use props.isHovered value also while setting the isHovered prop for the ReportActionItemImages.
isHovered={isScanning || props.isHovered}
OR
We can take out isScanning and only pass props.isHovered, bcoz for isScanning We are already providing background color for the parent View which covers these border part. So not needed here.

App/src/components/ReportActionItem/MoneyRequestPreview.js

Line 222 in 329cac3

<View style={[styles.moneyRequestPreviewBox, isScanning ? styles.reportPreviewBoxHoverBorder : undefined, ...props.containerStyles]}>

Result

https://github.com/Expensify/App/assets/14358475/4fa0287b-3775-45ef-864e-142021a86702

[Pujan92]

Just to add, it can be reproducible in the IOU report once it completes the Scan

[melvin-bot]

@johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

[johncschuster]

Thanks for adding that, @Pujan92! Can you rewrite the reproduction steps to include that? I'll update the OP with your clarifications.

[Pujan92]

@johncschuster Steps for reproduction

1. Create a money request with the scan option
2. Wait for the receipt to be scanned successfully
3. Hover on the money request in the IOU report
4. Observe the border color seems off and not match with the box highlight color

[johncschuster]

Thanks! I've updated the OP with those steps!