[HOLD for payment 2023-11-21][$1000] FAB - After a refresh, clicking back button on the 'I am a teacher' page does not take you back to the previous page

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on FAB
2. Click Save the World > I am a teacher
3. Click on the Update email address button
4. Refresh page.
5. Click on the back button

Expected Result:

Clicking back takes you to the 'I am a teacher' page

Actual Result:

Clicking back take you to profile page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.59-0

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

T139backbutton-1.mp4

Recording.1382.mp4

Expensify/Expensify Issue URL:

Issue reported by: @daveSeife

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693399672874879

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e00165b404e4216b
• Upwork Job ID: 1696904936518942720
• Last Price Increase: 2023-10-30
• Automatic offers:
• jjcoffee | Reviewer | 27440202
• paultsimura | Contributor | 27440206
• daveSeife | Reporter | 27440209

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @dangrous (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After refreshing a page on "I am a teacher > Update email" drawer, the "Go Back" button returns to Profile settings

What is the root cause of that problem?

On refresh, the navigation has no information about the previous page, so the goBack function navigates to the fallback route: ROUTES.SETTINGS_PROFILE

App/src/pages/settings/Profile/Contacts/ContactMethodsPage.js

Line 117 in d8b9cdd

onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_PROFILE)}

What changes do you think we should make in order to solve the problem?

Pass a URL parameter backTo while opening the "Edit Email" page, and use it as a fallback route for the "Go back" button:

const navigateBackTo = lodashGet(props.route, 'params.backTo', '');
...
<HeaderWithBackButton
                ...
                onBackButtonPress={() => Navigation.goBack(navigateBackTo)}
            />

What alternative solutions did you explore? (Optional)