[HOLD for payment 2023-10-02] [$500] IOS - Push notification is sent to the device even though the app is logged out.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Log in to Account A.
2. Turn OFF the network connection to enter OFFLINE mode.
3. LOG OUT
4. While the app is still in OFFLINE mode, send a message from another account to Account A (IMPORTANT STEP).
5. Turn ON the network connection.
6. Observer: Push notification appears.

Expected Result:

Push notification should not be sent if app is logged out

Actual Result:

Push notification is sent to the device even though the app is logged out.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.58.0 (tested on 1.3.62-3)
Reproducible in staging?: Yes
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Push-notification-issue.1.MP4

Expensify/Expensify Issue URL:
Issue reported by: @tranvantoan-qn
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692691382974179

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0134d9932ee5c7e512
• Upwork Job ID: 1698485880458186752
• Last Price Increase: 2023-09-03
• Automatic offers:
• hungvu193 | Contributor | 26547257
• tranvantoan-qn | Reporter | 26547259

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[tranvantoan-qn]

My Test/Reproduction note, hope it helps:

• Make sure that we allowed the app to recieve Notification by turning Notification permission ON (permission popup will be displayed after installing and openning app first time)
• The step 4: send a message from another account to Account A while the app is in OFFLINE mode - is a crucial step
• To make sure Push Notification will be sent properly via Firebase, please check Production build

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOS - Push notification is sent to the device even though the app is logged out.

What is the root cause of that problem?

Let take a look at the signOut function:

App/src/libs/actions/Session/index.js

Lines 41 to 56 in 6e17b64

	function signOut() {
	Log.info('Flushing logs before signing out', true, {}, true);
	API.write('LogOut', {
	// Send current authToken because we will immediately clear it once triggering this command
	authToken: NetworkStore.getAuthToken(),
	partnerUserID: lodashGet(credentials, 'autoGeneratedLogin', ''),
	partnerName: CONFIG.EXPENSIFY.PARTNER_NAME,
	partnerPassword: CONFIG.EXPENSIFY.PARTNER_PASSWORD,
	shouldRetry: false,
	});
	clearCache().then(() => {
	Log.info('Cleared all chache data', true, {}, true);
	});
	Timing.clearData();
	}

When user signed out offline, the API request will be pushed to the queue and wait for internet connection, after online again this api will be trigged and logged user out (including the token for push notification), in the mean time while signOut was calling if another user sent a message and user still can receive it because user was still logging out. This is the RCA. That why if you turned on the internet connection for a while and sent another message, you wouldn't receive the notification.

What changes do you think we should make in order to solve the problem?

I think the most simple way to resolve this issue is adding more condition to our shouldShowPushNotification function.

// call this when signout
shouldShowPushNotification {
 if (!isAuthenticated) {return false}
}

What alternative solutions did you explore? (Optional)

Add the following line to our PushNotification.deregister (index.native.js) function:

     Airship.push.setUserNotificationsEnabled(false);
    Airship.push.iOS.setForegroundPresentationOptionsCallback(() => Promise.resolve([]));
    Airship.push.android.setForegroundDisplayPredicate((pushPayload) => Promise.resolve(() => false));

[sophiepintoraetz]

Will test on Monday!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0134d9932ee5c7e512