[HOLD for payment 2023-09-08] Web - App Crashes when reloading after editing the Merchant

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Request money from user A
2. Go the report
3. Click on the Merchant to edit
4. Clear the field and click on Save
   Notice 'removed the merchant (previously "Request")' message appears
5. Refresh the page

Expected Result:

The app does not crash

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.58.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

T131.Appchrash-1.mp4

Recording.4065.mp4

Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693277798912359

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mountiny]

Merchant cannot be empty thats backend restriction, we probably need to add a validation here

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Not validating the merchant field to be required(not reproducing crash on the dev env)

What is the root cause of that problem?

We don't have any validation to restrict empty value for the merchant.

Reason for a crash: When we refresh the money request report we receive incorrect structure by ReconnectApi call for reportActions which leads to the transaction undefined and accessing fields of undefined crashes the app.

App/src/components/ReportActionItem/MoneyRequestView.js

Line 113 in 3f9f1e6

<OfflineWithFeedback pendingAction={lodashGet(transaction, 'pendingFields.amount') || lodashGet(transaction, 'pendingAction')}>

What changes do you think we should make in order to solve the problem?

Add validate function and pass it to the the Form by setting the merchant as a required field.

App/src/pages/EditRequestMerchantPage.js

Lines 43 to 45 in 3f9f1e6

	<TextInput
	inputID="merchant"
	name="merchant"

App/src/pages/iou/MoneyRequestMerchantPage.js

Lines 121 to 123 in 3f9f1e6

	<TextInput
	inputID="moneyRequestMerchant"
	name="moneyRequestMerchant"

const validate = (values) => {
        const requiredFields = ['merchant'];
        const errors = ValidationUtils.getFieldRequiredErrors(values, requiredFields);
        return errors;
    }

Same needs to be done for MoneyRequestMerchantPage component by using the field name moneyRequestMerchant.

Provide the default value in the lodashGet pendingFields.fieldname for pendingAction prop which we are passing to OfflineWithFeedback in the MoneyRequestView component. 1, 2, 3, 4

[MariaHCD]

cc: @koko57 Please let us know what you find, thanks!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[koko57]

@MariaHCD I couldn't reproduce it locally, I managed to reproduce it on staging so it's hard for me to tell for now what the exact RC is. I think that if we don't want to change the merchant to the empty string, the solution @Pujan92 proposes should work here

[Pujan92]

I am able to reproduce the crash locally also due to incorrect orders bcoz whenever we refresh the money request report we won't get pendingFields in the api onyx response which causes the issue(accessing undefined of pendingFields).

[MariaHCD]

That makes sense, thanks @Pujan92.

One thing about your proposal:

Reason for a crash might be: Conditions are in the wrong order for all the fields here. First, we need to check for pendingAction availability in the transaction and then check for specific child fields.

Do you mean we first need to check for pendingFields in the transaction before trying to fetch any child fields?