[$1000] Web - After request money, user is not seeing who sent the message in group conversation

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login with any account
2. Create a group with 3 people
3. Request money from Account A
4. Send message from Account B or C to the group conversation

Expected Result:

User can see who sent the message

Actual Result:

After request money, user is not seeing who sent the message in group conversation

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.57.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @vitHoracek
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692307206737309

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c73976e93aabc959
• Upwork Job ID: 1697342081334173696
• Last Price Increase: 2023-09-22

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

For immediate messages after requesting money, we do not show user details of who sent the message

What is the root cause of that problem?

We do not show the user details and it will be considered as displayAsGroup bcoz it is sent within the set time interval. For specific this scenario where the previous action is REPORTPREVIEW we don't have any specific condition to allow it to show the user details.
For eg.

1. User A requests money from User B
2. User B id will be as actorAccountID for the created ReportPreview action
3. Now if User B sends any message it will fall under displayAsGroup due to the same actorAccountID and we do not show their details

What changes do you think we should make in order to solve the problem?

We need to add a new condition where we won't consider the current action as displayAsGroup for below scenarios

• When the previous action is REPORTPREVIEW and current action isn't
• When the previous and current both actions are REPORTPREVIEW but the actorAccountID is not the same
• When the current action is REPORTPREVIEW but the previous action isn't
  

  App/src/libs/ReportActionsUtils.js

  Lines 263 to 269 in c029dc5

  	if (!currentAction || !previousAction) {
  	return false;
  	}
  	// Comments are only grouped if they happen within 5 minutes of each other
  	if (new Date(currentAction.created).getTime() - new Date(previousAction.created).getTime() > 300000) {
  	return false;

   if(isReportPreviewAction(previousAction)) {
        if(isReportPreviewAction(currentAction) && currentAction.actorAccountID === previousAction.actorAccountID) {
            return true;
        }
        return false;
    }
    
    if(isReportPreviewAction(currentAction) && !isReportPreviewAction(previousAction) && currentAction.actorAccountID === previousAction.actorAccountID) {
        return false;
    }

Current	After Fix

[melvin-bot]

@puneetlath Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c73976e93aabc959

[melvin-bot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)