[C+ Checklist Needs Completion] [$250] Fix styling of Google Sign In button on Safari

[dangrous]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Break down in numbered steps

• Open the main page on desktop Safari, with Apple and Google sign in links

Expected Result:

Describe what you think should've happened

• Google button should appear in full, and stay static once loaded

Actual Result:

Describe what actually happened

• The G part of the button looks fine, but right after it loads the white background shifts one pixel right and is cut off by that amount.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Yes

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Safari
• MacOS / Desktop

Version Number: 1.3.57-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: https://expensify.slack.com/archives/C01GTK53T8Q/p1692805800476329?thread_ts=1692802374.824749&cid=C01GTK53T8Q

hidden.mp4

Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1692805800476329?thread_ts=1692802374.824749&cid=C01GTK53T8Q

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0131c050705af6ac9f
• Upwork Job ID: 1695197552733020160
• Last Price Increase: 2023-08-25
• Automatic offers:
• Pujan92 | Contributor | 26508718

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Google sign in button cuts from right in safari

What is the root cause of that problem?

Seems after adding overflow hidden in this PR started causing the issue. When parent width and overflow hidden gets given it seems to create the problem for safari.
https://stackoverflow.com/questions/75306089/safari-when-using-border-radius-and-overflow-hidden-to-parent-and-the-child-th

What changes do you think we should make in order to solve the problem?

We can use styles.willChangeTransform(will-change: transform) for the layout glitch for the safari as suggested in the comment and I think we are already using the same at other places.

App/src/components/SignInButtons/GoogleSignIn/index.website.js

Line 80 in 165e1b8

<View style={styles.googleButtonContainer}>

<View style={[styles.googleButtonContainer, styles.willChangeTransform]}>

OR

We can increase the width of the container and apply some padding so it cut part can be visible on the padding area.

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[greg-schroeder]

Setting this to $250 as a minor adjustment

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0131c050705af6ac9f

[melvin-bot]

Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (External)