[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$1000] Web - When input exceeds 500k characters, the web freezes.

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to Create a New Chat, New Group, or New Task.
2. Input exceeds 500k characters into the search bar or title.

Expected Result:

The website does not crash when entering long text.

Actual Result:

The website is frozen or crash

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.56-21

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Crash.1.mp4

Crash.2.mp4

Recording.1308.mp4

Expensify/Expensify Issue URL:

Issue reported by: @LeThiThuThuy

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691988614374279

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ffb0be0940793404
• Upwork Job ID: 1696326036875673600
• Last Price Increase: 2023-09-19

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ahmedGaber93]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When input exceeds 500k characters, the web freezes.

What is the root cause of that problem?

There is no maxLength prop in OptionsSelector which make TextInput accept infinity length of text

What changes do you think we should make in order to solve the problem?

To achieve the desired design, we need

1. in BaseOptionsSelector.js we will set default prop for maxLength equal CONST.SEARCH_MAX_LENGTH (we will create this const = 500 or what we agree on), and we still can control using prop maxLength={100} if needed.

2. because we allow the user to enter text more than maxLength (101/100), but we don't need to display result for it, we need to save the input value in internal state in BaseOptionsSelector.js to can get its length and stop pass it up by this.props.onChangeText(value) when maxLength reach

updateSearchValue(value){
    if (value.length > this.props.maxLength) {
        this.setState({
            errorMessage: this.props.translate("common.error.characterLimitExceedCounter", {length: value.length, limit: this.props.maxLength}),
            searchValue: value,
        });
        return;
    }

    this.setState({
        errorMessage: "",
        searchValue: value,
    });

    this.props.onChangeText(value);
}
    
<TextInput
    value={this.state.searchValue}
    onChangeText={this.updateSearchValue}
    errorText={this.state.errorMessage}
    maxLength={this.props.maxLength + CONST.ERROR_EXCEED_RANGE}

3. stop display "no result found" when found error

headerMessage={this.state.errorMessage ? "" : this.props.headerMessage}

Screen.Recording.2023-10-03.at.12.29.53.AM.mov

my branch

What alternative solutions did you explore? (Optional)

N/A

[jeet-dhandha]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Issue is that on pasting longer text in composer, it slows down the browser. As processing longer text takes time, low end devices are affected more.

What is the root cause of that problem?

• The root cause is that the text is processed in one go. So, the browser is busy processing the text and can't do anything else.

What changes do you think we should make in order to solve the problem?

• We can add a limit on paste event. So, if the text is longer than the limit we can show Paste Limit Exceeded error.

• Another option is to clip the text to the limit and show Paste Limit Exceeded error.

• Finally remove the Paste Limit Exceeded error after 1.5s.

What alternative solutions did you explore? (Optional)

• N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ffb0be0940793404

[melvin-bot]

Current assignee @johncschuster is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)