[HOLD for payment 2023-09-29] [$1000] Web - No Transition animation for task assignee/share-somewhere modal

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click FAB, Click Assign task
2. Enter title, click continue.
3. Click on Assignee Option, see there is no animation.
4. Click on Share somewhere, see there is no animation.

Expected Result:

There should be animation for the 2 screen/modals

Actual Result:

No Animation

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.56-21

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Kapture.2023-08-13.at.02.21.01.mp4

Recording.1307.mp4

Expensify/Expensify Issue URL:

Issue reported by: @b4s36t4

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691873619811189

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d36654a811c7c838
• Upwork Job ID: 1696763981295181824
• Last Price Increase: 2023-08-30
• Automatic offers:
• b4s36t4 | Contributor | 26515110
• b4s36t4 | Reporter | 26515112

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[izarutskaya]

Proposal from @b4s36t4

Please re-state the problem that we are trying to solve in this issue.

No Transition animation for task assignee/share-somewhere modal

What is the root cause of that problem?

RCA for this issue is with the inputs we have inside these modals which are getting instant focus causing the break in animation.

What changes do you think we should make in order to solve the problem?

We can solve this issue with two methods

1. Using shouldDelayFocus prop should do that work.
2. Using the ref to access textInput ref inside the BaseOptionsSelector component and focus the input after animation done inside the onEntryTransitionEnd prop for ScreenWrapper component.
   Reference: fix: workspace members invite page transition #22217 Kind of same issue.

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

@JmillsExpensify Huh... This is 4 days overdue. Who can take care of this?

[JmillsExpensify]

Fair enough. I'm triaging this one.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d36654a811c7c838

[melvin-bot]

Current assignee @JmillsExpensify is eligible for the External assigner, not assigning anyone new.