[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [$1000] Chat - Accessing an attachment via link that is not found shows the error page twice

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #25516

Action Performed:

1. Open app New Expensify
2. Log in
3. Open any chat/report
4. Send this link https://staging.new.expensify.com/r/7736083827006365/attachment?source=/chat-attachments/8443634480793859480/w_3de27a40d82c4442386d0447d8dab8af403f786f3.png
5. Tap on the link
6. Tap on the back button

Expected Result:

The user should be taken to the chat and stay there

Actual Result:

The error page opens again, so that the user has to close it again

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.56.18

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6174639_Xefe3282_1_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016d69185d9da05b9b
• Upwork Job ID: 1694891980872962048
• Last Price Increase: 2023-09-15
• Automatic offers:
• tienifr | Contributor | 27121583

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[jeet-dhandha]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Hmm...its not here - page is coming up twice for an attachment which we do not have access to.

What is the root cause of that problem?

• The page is coming up first time when we are trying to access the attachment.
• Second time its coming up when we press back button on attachment modal. As its trying to navigate to a reportID which we do not have access to and thus showing Hmm...its not here page.

What changes do you think we should make in order to solve the problem?

• We can update the dismissModal function of Navigation.js to check if any report is available for given targetReportID.

• And also we will have to remove isLoadingReportActions key from the found report as it will set key for unknown report in onyx.

• Finally, After changes if we press on back it should just close the Attachment Modal.

What alternative solutions did you explore? (Optional)

• N/A

[marcaaron]

@lanitochka17 What platforms is this related to? I can't reproduce on web. Please provide clear reproduction steps.

I don't think this needs to be a blocker. Getting linked to an attachment that doesn't exist seems like a minor flow.

[jeet-dhandha]

@marcaaron Try these steps:

1. Open the “Android” app.
2. Send the above link in one of your chat.
3. Press on the link and after that verify the not found page in attachment modal.
4. Press back on top and verify the not found page displaying second time.