[HOLD for payment 2023-09-11] [$2000] Fix issue with Map panning behavior

[hayata-suenaga]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Context

A new feature was added in this PR recently where we display a map. We discovered an issue with the map's behavior though. We need a fix as soon as possible.

We also introduced a new library for this map feature. The library's repo is here: https://github.com/Expensify/react-native-x-maps.

The map should zoom into an area when a single waypoint is passed. When several waypoints are passed, the map should pan out to fix all waypoints passed on map. These zoom in and pan out movements are not working on iOS and Android.

The last version of the library above is 1.0.10 and the version specified in App's package.json on the main branch is 1.0.9. But this should not be the cause of the issue, I believe

Related issues

• Android - IOU Distance - Map does not zoom in to the selected location on Start point #25871 (comment)

Hint

The root cause of this issue might be inside react-native-x-maps. If you need to modify the library code and test changes in App, you can push changes in x-maps to a forked repo on GitHub and use the link of your branch on GitHub to install the changed code in your App. More info on this here

Action Performed:

This issue exists on the main branch. It should be re-producible on iOS and Android.

1. Pull the latest main

2. Open NewDot on iOS simulator or Android emulator

3. Go to any chat room where you can request money (i.e. IOU)

4. Click the "+" icon next to the chat message text field. Click "Request Money" on the pop up menu that appears.

5. Check "Distance" tab on the Right Hand Panel that appears

6. Click the "Start" item from the list of waypoints.

7. In the text field that appears in the next screen, type "88 Kearny Street". Click the first option "88 Kearny Street, San Francisco, CA, USA" that appears.
   

8. Check that the map doesn't move when it should zoom into a part of San Francisco. Check the video below for the expected behavior of the map (taken on Web).

   Current behavior

   Screen.Recording.2023-08-23.at.1.25.35.PM.mov
   Expected behavior

   Screen.Recording.2023-08-22.at.4.01.02.PM.mov

9. Click the "Stop" item from the list of waypoints.

10. In the text field that appears in the next screen, type "Golden Gate Park". Click the first option "88 Kearny Street, San Francisco, CA, USA" that appears.

11. Check that the map doesn't move at all when it should pan out to fix the new point added. Check the video below for the expected behavior of the map (taken on Web).

    Current behavior

    Screen.Recording.2023-08-23.at.1.28.41.PM.mov
    Expected behavior

    Screen.Recording.2023-08-22.at.4.08.56.PM.mov

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Reproducible in staging?: Only on main
Reproducible in production?: Nop
Slack conversation: #25161 (comment)

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0167825771cb68ae59
• Upwork Job ID: 1694128479546347520
• Last Price Increase: 2023-08-24

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0167825771cb68ae59

[melvin-bot]

Current assignee @NicMendonca is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @allroundexperts is eligible for the External assigner, not assigning anyone new.

[hayata-suenaga]

@NicMendonca I created this issue from this Slack discussion. This is probably regression from a PR that I created for the Wave 5 Distance Request project. You don't have to reproduce this issue. I already confirmed that the issue exists.

I assigned @allroundexperts because they're very involved in the Wave 5 project and has the necessary context.

@allroundexperts if you come up with the solution, you can also create a PR yourself 🙇

[ShogunFire]

I have an error:
"Mapbox error MapLoad error Failed to load glyphs:
HTTP status code 403"

[hayata-suenaga]

I have an error:
"Mapbox error MapLoad error Failed to load glyphs:
HTTP status code 403"

thank you for reporting but this issue is known and the fix should be merged soon