[HOLD for payment 2023-09-04] Security - notFound.goBackHome message appears after disabling 2FA authentication

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #23060

Action Performed:

Precondition: Have 2FA set up.

1. Launch New Expensify app.
2. Go to Settings > Security > Two-factor authentication.
3. Tap Disable two-factor authentication.

Expected Result:

There is no error message

Actual Result:

notFound.goBackHome message appears after disabling 2FA authentication
This error message also appears in different page in apps, like the map in Distance tab when going offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• Windows / Chrome
• MacOS / Desktop

Version Number: 1.3.56-2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6173011_Screen_Recording_20230822_102533_New_Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[aimane-chnaif]

Regression from #25164

[allroundexperts]

I think this is not a regression. The above mentioned PR just made this visible.

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

notFound.goBackHome is not translated.

What is the root cause of that problem?

The real issue here is that here, we're specifying a default link of value notFound.goBackHome but we're never translating it

What changes do you think we should make in order to solve the problem?

We should change this line to:

link: ''

Inside the component, we can destructure link as originalLink and add the following line:

const link = originalLink ?? localize.translate('notFound.goBackHome');

What alternative solutions did you explore? (Optional)

None

[narefyev91]

The real issue here is that here, we're specifying a default link of value notFound.goBackHome but we're never translating it. We should change the above mentioned line to:

Localize.translate(`notFound.goBackHome`)

Agree with @allroundexperts

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Default link not gets trnaslated

What is the root cause of that problem?

When we pass shouldShowLink and default link is not we are translating that is the issue.

What changes do you think we should make in order to solve the problem?

Remove translation from FullPageNotFoundView by passing only key and apply translation only in the BlockingView

App/src/components/BlockingViews/FullPageNotFoundView.js

Line 72 in 494847a

link={props.translate(props.linkKey)}