[HOLD for payment 2023-09-04] [$1000] Split Bill - All user names are showing in IOU

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Access staging.new.epensify.com
2. Sign into a valid account
3. Split bill

Expected Result:

User expects that the preview shows the users images and not names

Actual Result:

All split bill user names and date is displayed in the IOU

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• Windows / Chrome
• MacOS / Desktop

Version Number: 1.3.56-2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017a8059f6b6485a78
• Upwork Job ID: 1693876610499690496
• Last Price Increase: 2023-08-22
• Automatic offers:
• jjcoffee | Reviewer | 26263054
• s-alves10 | Contributor | 26263056

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[pradeepmdk]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Split Bill - All user names are showing in IOU

What is the root cause of that problem?

App/src/libs/ReportUtils.js

Line 1249 in c053381

merchant: TransactionUtils.getMerchant(transaction),

based on its showing the merchant name
this pr enabled the merchant https://github.com/Expensify/App/pull/25449/files

What changes do you think we should make in order to solve the problem?

App/src/libs/actions/IOU.js

Line 627 in c053381

`${Localize.translateLocal('iou.splitBill')} ${Localize.translateLocal('common.with')} ${formattedParticipants} [${DateUtils.getDBTime().slice(0, 10)}]`,

here we are generating the merchant and pass

App/src/libs/TransactionUtils.js

Line 69 in c053381

merchant: merchant || CONST.REPORT.TYPE.IOU,

and here we are using that

App/src/components/ReportActionItem/MoneyRequestPreview.js

Lines 257 to 261 in 120bcbf

	{requestMerchant && (
	<View style={[styles.flexRow]}>
	<Text style={[styles.textLabelSupporting, styles.mb1, styles.lh16]}>{requestMerchant}</Text>
	</View>
	)}

!_.isEmpty(requestMerchant) && requestMerchant === CONST.REPORT.TYPE.IOU 

we need to add a condition here it will show only CONST.REPORT.TYPE.IOU,

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

All user names appears in split bill

What is the root cause of that problem?

This is a regression from this PR

We create merchant info optimistically when we create split bill here

App/src/libs/actions/IOU.js

Line 627 in 120bcbf

`${Localize.translateLocal('iou.splitBill')} ${Localize.translateLocal('common.with')} ${formattedParticipants} [${DateUtils.getDBTime().slice(0, 10)}]`,

We show merchant info below

App/src/components/ReportActionItem/MoneyRequestPreview.js

Lines 257 to 261 in 120bcbf

	{requestMerchant && (
	<View style={[styles.flexRow]}>
	<Text style={[styles.textLabelSupporting, styles.mb1, styles.lh16]}>{requestMerchant}</Text>
	</View>
	)}

This is the root cause

What changes do you think we should make in order to solve the problem?

I don't think we need to show merchant information in money request preview

Replacing the merchant part in the MoneyRequestPreview will solve the issue

with

 {!props.isBillSplit && requestMerchant && ( 
     <View style={[styles.flexRow]}> 
         <Text style={[styles.textLabelSupporting, styles.mb1, styles.lh16]}>{requestMerchant}</Text> 
     </View> 
 )}

This works as expected

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017a8059f6b6485a78