[HOLD for payment 2023-09-04] [mWeb Safari] Date is trimmed on small devices when creating manual requetst

[mountiny]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Coming from #25449 (review)

Device: iPhone SE 3rd gen.

Steps:

1. Create a manual request
2. Set the date as 2023-08-01

Expected: 2023-08-01 is visible on confirm money request page
Actual: 2023-08-... is shown on confirm money request page

Screen.Recording.2023-08-19.at.02.39.57.mov

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @rushatgabhane
Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[BeeMargarida]

Hi, I'm Ana from Callstack - expert contributor group - I would like to work on this issue

[akinwale]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Date is trimmed on small devices (e.g. iPhone SE 3rd gen) when requesting money manually.

What is the root cause of that problem?

flexShrink1 in titleTextStyle is causing the date to get truncated.

App/src/components/MenuItem.js

Line 85 in 03cf0b1

styles.flexShrink1,

What changes do you think we should make in order to solve the problem?

Solution 1
Change the flexShrink1 style to flex1.

Solution 2
Considering that Solution 1 may lead to a regression (I need to do more testing for this to be sure), we can instead add a prop to MenuItem to conditionally override the style, and set this prop specifically for the Date field display.

What alternative solutions did you explore? (Optional)

None.

[BeeMargarida]

@rushatgabhane @mountiny I can't seem to replicate this, it seems fixed. Can you replicate? (I've used both @mountiny branch and the main branch)

iPhone SE 3rd generation	devTools to simulate a Galaxy S5
ios_d_t.mp4	browser_d_t.mp4

[akinwale]

@BeeMargarida It's reproducible in the iOS 16.2 simulator.

[mountiny]

@BeeMargarida Can you test on the PR where @rushatgabhane found it too? Its in the Create money request flow