[HOLD for payment 2023-09-11] [HOLD for payment 2023-09-08] [$1000] CTRL+K, CTRL+SHIFT+K and CTRL+K again closes everything

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Click CTRL+K, it should open search
3. Click CTRL+SHIFT+K, it should open new group search
4. Again click CTRL+K, it closes everything instead of opening search

Expected Result:

App should reopen search page when we again click CTRL+K after CTRL+K, CTRL+SHIFT+K

Actual Result:

App closes everything when we again click CTRL+K after CTRL+K, CTRL+SHIFT+K

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.55-3
Reproducible in staging?: y
**Reproducible in production?:**n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

CTRL.K.again.closes.everything.mp4

Recording.1483.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692434730707179

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e2284d0efa12310e
• Upwork Job ID: 1693613839544455168
• Last Price Increase: 2023-08-21
• Automatic offers:
• Ollyws | Reviewer | 26306881
• shubham1206agra | Contributor | 26306882
• dhanashree-sawant | Reporter | 26306883

[melvin-bot]

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @dangrous (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[pradeepmdk]

Proposal

Please re-state the problem that we are trying to solve in this issue.

CTRL+K, CTRL+SHIFT+K and CTRL+K again closes everything

What is the root cause of that problem?

App/src/libs/Navigation/linkTo.js

Lines 62 to 74 in 58dc0c9

	if (action.type === 'NAVIGATE') {
	// If this action is navigating to the report screen and the top most navigator is different from the one we want to navigate - PUSH
	if (action.payload.name === NAVIGATORS.CENTRAL_PANE_NAVIGATOR && getTopmostReportId(root.getState()) !== getTopmostReportId(state)) {
	action.type = 'PUSH';
	// If the type is UP, we deeplinked into one of the RHP flows and we want to replace the current screen with the previous one in the flow
	// and at the same time we want the back button to go to the page we were before the deeplink
	} else if (type === 'UP') {
	action.type = 'REPLACE';
	// If this action is navigating to the RightModalNavigator and the last route on the root navigator is not RightModalNavigator then push
	} else if (action.payload.name === NAVIGATORS.RIGHT_MODAL_NAVIGATOR && _.last(root.getState().routes).name !== NAVIGATORS.RIGHT_MODAL_NAVIGATOR) {
	action.type = 'PUSH';

here on the right side navigate present NewGroup_Root and Search_Root both are in different stack navigators once is first time opened it will use push to dispatch when second-time shortcut key pressed navigation will happen at the time state not updating so again pressed whatever in the state its closed.

What changes do you think we should make in order to solve the problem?

by using REPLACE we can update the state in the navigation.

return Navigation.navigate(ROUTES.SEARCH, CONST.NAVIGATION.TYPE.UP);
return Navigation.navigate(ROUTES.NEW_GROUP, CONST.NAVIGATION.TYPE.UP);

in up
action.type = 'REPLACE';
replace the route.