[HOLD for payment 2023-10-18] [$500] Web - Chat - Able to type in composer while popover is open

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open any chat
2. Right click on any message
3. Write anything from keyboard
4. Observe composer

Expected Result:

When any popover is open, composer should be blurred and not able to type in composer

The fix should not break the current behavior (when none of the popover or RHP modal is open, typing anything should focus on the composer automatically but not paste)

Actual Result:

You're able to type via the composer

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.55-4

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug.mp4

Recording.5913.mp4

Expensify/Expensify Issue URL:

Issue reported by: @aimane

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691526238059509

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fecf2f053b61b171
• Upwork Job ID: 1693637662419955712
• Last Price Increase: 2023-10-19
• Automatic offers:
• aimane-chnaif | Reviewer | 27015731
• mkhutornyi | Contributor | 27015733

Issue Owner

Current Issue Owner: @maddylewis

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Chat - Able to type in composer while popover is open

What is the root cause of that problem?

1. The report action context menu is passing the withoutOverlay to the Popover, that means it would like to use new PopoverWithoutOverlay that is just introduced recently. Because our new PopoverWithoutOverlay is not base modal anymore, it wont call Modal.setModalVisibility to set it's true when a modal is opened.
2. In the Report composer, we have a keypress listener, it will focus on composer if the isComposerVisible is true

   App/src/pages/home/report/ReportActionCompose.js

   Lines 712 to 721 in dd2c98b

   	checkComposerVisibility() {
   	const isComposerCoveredUp = EmojiPickerActions.isEmojiPickerVisible() || this.state.isMenuVisible || this.props.modal.isVisible;
   	return !isComposerCoveredUp;
   	}
   	focusComposerOnKeyPress(e) {
   	const isComposerVisible = this.checkComposerVisibility();
   	if (!isComposerVisible) {
   	return;
   	}

Currently, we only check EmojiPickerActions.isEmojiPickerVisible, this.state.isMenuVisible and this.props.modal.isVisible. We haven't checked the new PopoverWithoutOverlay open state yet to check whether if the composer is covered up by context menu.

What changes do you think we should make in order to solve the problem?

The isOpen state of new PopoverWithoutOverlay is in the PopoverContextProvider, we can consume this context in the ReportActionCompose component, then check the isOpen state of new PopoverWithoutOverlay in this function as well

App/src/pages/home/report/ReportActionCompose.js

Lines 712 to 715 in dd2c98b

	checkComposerVisibility() {
	const isComposerCoveredUp = EmojiPickerActions.isEmojiPickerVisible() || this.state.isMenuVisible || this.props.modal.isVisible;
	return !isComposerCoveredUp;
	}

If it's true, we should return false for that function too. Then in the keypress listener, it will early exit because the composer is not visible here

[aimane-chnaif]

@hoangzinh your proposal makes sense but unfortunately it might cause regression of not being able to paste even when composer is focused, especially when LHN popover is open

Screen.Recording.2023-08-18.at.6.13.17.PM.mov

Solution:

1. always blur composer when any popover is open
2. keep composer focused state as is now and still let user type or paste in composer when focused

@maddylewis which option do you suggest?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fecf2f053b61b171

[melvin-bot]

Current assignee @maddylewis is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @aimane-chnaif is eligible for the External assigner, not assigning anyone new.